ref: replace concrete TargetFramework string comparisons with TargetFrameworkIdentifier/Version properties #5240
2 issues
Low
`.NETStandard` condition missing version qualifier, broader than intended - `src/Sentry.Extensions.Logging/Sentry.Extensions.Logging.csproj:18`
The condition was narrowed from the full netstandard2.0 match but the version pin was dropped — '$(TargetFrameworkIdentifier)' == '.NETStandard' matches any NETStandard version, while the PR's own stated mapping and Sentry.Serilog.csproj (another file in this PR) both include And '$(TargetFrameworkVersion)' == 'v2.0'. If netstandard2.1 is ever added to TargetFrameworks, the v2.1.0-pinned packages would be incorrectly applied to it.
Also found at:
test/Sentry.DiagnosticSource.IntegrationTests/Sentry.DiagnosticSource.IntegrationTests.csproj:37
`.NETFramework` condition omits version check, deviating from PR's own stated mapping - `test/Sentry.DiagnosticSource.Tests/Sentry.DiagnosticSource.Tests.csproj:30`
The condition '$(TargetFrameworkIdentifier)' == '.NETFramework' is missing the version guard And '$(TargetFrameworkVersion)' == 'v4.8' that the PR description explicitly documents as the correct replacement for '$(TargetFramework)' == 'net48'. This makes the condition match any .NET Framework version, not just 4.8.
Also found at:
src/Sentry.Extensions.Logging/Sentry.Extensions.Logging.csproj:18-21
4 skills analyzed
| Skill | Findings | Duration | Cost |
|---|---|---|---|
| security-review | 0 | 5.2s | $0.19 |
| code-review | 1 | 55.1s | $0.73 |
| find-bugs | 1 | 2m 58s | $1.20 |
| gha-security-review | 0 | 51.2s | $0.12 |
⏱ 4m 50s · 492.5k in / 41.2k out · $2.23