Skip to content

exec-file/exec-env: reset supplementary groups when changing user #2194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
felixfontein wants to merge 2 commits into
base: main
Choose a base branch
from
Open

exec-file/exec-env: reset supplementary groups when changing user #2194

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
759b608
Reset supplementary groups when changing user.
felixfontein May 25, 2026
82a1b8f
Address review comments.
felixfontein May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions cmd/sops/subcommand/exec/exec_unix.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,11 @@ func SwitchUser(username string) {
uid, _ := strconv.Atoi(user.Uid)
gid, _ := strconv.Atoi(user.Gid)

err = syscall.Setgroups([]int{gid})
Copy link
Copy Markdown
Contributor

@sabre1041 sabre1041 May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we looking to map the supplemental groups for the specified user or reset it so that it only contains the primary group?

Mapping could be accomplished by something similar to the following

	groupIds, _ := user.GroupIds()
	intGroupIds := make([]int, len(groupIds))
	for i, gid := range groupIds {
		intGroupIds[i], _ = strconv.Atoi(gid)
	}

	err = syscall.Setgroups(intGroupIds)
	if err != nil {
		log.Fatal(err)
	}

Copy link
Copy Markdown
Contributor Author

@felixfontein felixfontein May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I missed user.GroupIds(). Yeah, that makes sense. I've changed it slightly so that it falls back to []int{gid} if GroupIds() returns an error.

if err != nil {
log.Fatal(err)
}

err = syscall.Setgid(gid)
if err != nil {
log.Fatal(err)
Expand Down