Skip to content

fix: load docker-compose.override.yml in compose function - #2161

Open
ErnestHysa wants to merge 1 commit into
getumbrel:masterfrom
ErnestHysa:fix/override-compose
Open

fix: load docker-compose.override.yml in compose function#2161
ErnestHysa wants to merge 1 commit into
getumbrel:masterfrom
ErnestHysa:fix/override-compose

Conversation

@ErnestHysa

Copy link
Copy Markdown

Fixes #2132 — compose() never loads docker-compose.override.yml.

This adds a check after the compose files are built to append the override file if it exists.

@agent932 agent932 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this fix on a live umbrelOS install — confirms the behaviour described in #2132.

Applied the patch manually to /usr/local/lib/node_modules/umbreld/source/modules/apps/legacy-compat/app-script, placed a docker-compose.override.yml in the Plex app data directory with a custom volume mount (/mnt/UNAS-PlexStorage), and restarted. docker inspect confirmed the override was applied correctly.

Also validated update survivability: overwrote docker-compose.yml with the app store template (simulating an app update), restarted, and the override was still picked up cleanly. Apps without an override file were unaffected.

LGTM — clean, minimal, correct.

@DavidBurela

Copy link
Copy Markdown

I tried applying the patch locally as well.
Worked cleanly. The values in docker-compose.override.yml were correctly applied to the container.

@jjmmbb

jjmmbb commented Jul 13, 2026

Copy link
Copy Markdown

When will this be released? A very simple and extremly important change.

@agent932

Copy link
Copy Markdown

Hi @getumbrel, this PR addresses #2132 by enabling override compose files as documented. All tests pass and the change is minimal. Could you review when you have a chance? Thanks!

@agent932

Copy link
Copy Markdown

@lukechilds is there anything else I need to do for this PR?

@jjmmbb

jjmmbb commented Jul 25, 2026

Copy link
Copy Markdown

When will this fix be included in the UmbrelOS update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: compose() in app-script does not load docker-compose.override.yml

4 participants