fix: add /usr/sbin and /sbin to PATH in update-script - #2163
Open
ErnestHysa wants to merge 1 commit into
Open
Conversation
The update subprocess spawned by umbreld inherits a PATH that does not include /usr/sbin or /sbin, causing rugix-ctrl to fail with 'No such file or directory' when it tries to run sfdisk to read the partition table during OS updates. This results in the update hanging at 93% with the bundle fully written but the boot-slot switch never happening. This fix follows the suggested approach from issue getumbrel#2153: adding the standard sbin directories to PATH at the top of the update-script, scoping the change to the update flow only. Fixes: getumbrel#2153
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
update-scriptdoes not include/usr/sbinor/sbinin its PATH, causingrugix-ctrlto fail withNo such file or directorywhen it runssfdisk(located at/usr/sbin/sfdisk) during OS updates. This was reported in issue #2153.As described in that issue:
system.updateStatusreportsrunning: trueindefinitelyFix
Added the standard sbin directories to PATH at the top of
scripts/update-script:This follows the suggested approach from the issue — it scopes the PATH fix to the update flow only, making it a safe and targeted change.
Testing
The issue author verified that running
rugix-ctrl system infowith the same truncated PATH reproduces the error. With the PATH corrected, sfdisk is found and rugix-ctrl can read the partition table.Fixes #2153