[sagudev]

Connections

Towards #10073

spec issue: gpuweb/cts#4708
spec change: gpuweb/gpuweb#10971
CTS change: gpuweb/cts#4713

Description

Similarly as in #10315 we need to pass GPUMapModeFlags as bitflags, so we can do move validation from content process in GPU processes. Ordering of validation checks is important here (https://gpuweb.github.io/gpuweb/#dom-gpubuffer-mapasync):

2. If any of the following conditions are unsatisfied:

• this.[[device]] must be valid.

...

Reject p with an AbortError.

3. If any of the following conditions are unsatisfied:

• this must be valid

• mode contains only bits defined in GPUMapMode.

• mode contains exactly one of READ or WRITE.

...
Reject p with an OperationError.

To make it easier to code in downstream consumers which use MapModeFlags we also return resolved MapMode into the callback (instead of returning ()).

Many deno commits is made to make all webgpu:api,validation,buffer,mapping:* tests work. The main thing is that we need to limit scope of OpState refcell borrows to prevent crashes, and drain microtask queue before resolving promise (to get deferred promise behavior). I did try to follow spec to the letter by returning promise object and resolving it from callback in sagudev@1dcc79c, but tokio tasks are not part of deno's event loop so event loop might complete before promise resolves thus no tests are actually done before we are done executing event loop.

Testing

New deno test enabled, and webgpu:api,validation,buffer,mapping:mapAsync,destroyedDevice:* also passes.

Squash or Rebase?

Rebase

LLM Use?

None

Checklist

• I self-reviewed and fully understand this PR.
• CHANGELOG.md entries for the user-facing effects of this change are present.
• The PR is minimal, and doesn't make sense to land as multiple PRs.
• Commits are logically scoped and individually reviewable.
• The PR description has enough context to understand the motivation and solution implemented.
• (If applicable) WebGPU implementations built with wgpu may be affected behaviorally.
• (If applicable) Validation and feature gates are in place to confine behavioral changes.
• (If applicable) Tests demonstrate the validation and altered logic works.

[teoxoy]

Great stuff!

[teoxoy]

@Mergifyio queue