Skip to content

refactor/reduce-tree.go-addRoute-length #4643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
72sevenzy2 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor/reduce-tree.go-addRoute-length #4643

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions tree.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,18 +130,28 @@ func (n *node) incrementChildPrio(pos int) int {
return newPos
}

func (n *node) compareEmptyTree(path string, fullPath string, handlers HandlersChain) {
if len(n.path) == 0 && len(n.children) == 0 {
n.insertChild(path, fullPath, handlers)
n.nType = root
return
}
}

// addRoute adds a node with the given handle to the path.
// Not concurrency-safe!
func (n *node) addRoute(path string, handlers HandlersChain) {
fullPath := path
n.priority++

// Empty tree
if len(n.path) == 0 && len(n.children) == 0 {
n.insertChild(path, fullPath, handlers)
n.nType = root
return
}
// // Empty tree
// if len(n.path) == 0 && len(n.children) == 0 {
// n.insertChild(path, fullPath, handlers)
// n.nType = root
// return
// }

n.compareEmptyTree(path, fullPath, handlers)

parentFullPathIndex := 0

Expand Down
Loading