fix(binding): support multipart/mixed form parsing (#2547)#4684
Draft
ljluestc wants to merge 1 commit into
Draft
fix(binding): support multipart/mixed form parsing (#2547)#4684ljluestc wants to merge 1 commit into
ljluestc wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4684 +/- ##
==========================================
- Coverage 99.21% 97.71% -1.51%
==========================================
Files 42 50 +8
Lines 3182 3190 +8
==========================================
- Hits 3157 3117 -40
- Misses 17 55 +38
- Partials 8 18 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
变更内容
1) 新增
multipart/mixedMIME 常量与默认绑定映射binding层新增MIMEMultipartMixed = "multipart/mixed"binding.Default(...)对multipart/mixed返回FormMultipartgin包导出同名常量,保持与现有 MIME 常量暴露方式一致2) 引入 multipart 解析兜底逻辑
新增统一辅助函数
parseMultipartForm(req, maxMemory)(分别在binding包与gin包):req.ParseMultipartForm(maxMemory)ErrNotMultipart,且Content-Type为multipart/mixed:req.MultipartReader().ReadForm(maxMemory)解析req.MultipartFormreq.PostForm与req.Form,保证后续取值路径兼容