Skip to content

refactor: optimize error message concatenation in default_validator#4685

Open
wanghaolong613 wants to merge 1 commit into
gin-gonic:masterfrom
wanghaolong613:refactor/slice-error-string
Open

refactor: optimize error message concatenation in default_validator#4685
wanghaolong613 wants to merge 1 commit into
gin-gonic:masterfrom
wanghaolong613:refactor/slice-error-string

Conversation

@wanghaolong613
Copy link
Copy Markdown
Contributor

refactor: optimize error message concatenation in default_validator

Use separate WriteString calls instead of '+' operator for building
error messages in SliceValidationError to reduce memory allocations.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.37%. Comparing base (3dc1cd6) to head (2c2a0ce).
⚠️ Report is 276 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4685      +/-   ##
==========================================
- Coverage   99.21%   98.37%   -0.84%     
==========================================
  Files          42       48       +6     
  Lines        3182     3141      -41     
==========================================
- Hits         3157     3090      -67     
- Misses         17       42      +25     
- Partials        8        9       +1     
Flag Coverage Δ
?
--ldflags="-checklinkname=0" -tags sonic 98.36% <100.00%> (?)
-tags go_json 98.29% <100.00%> (?)
-tags nomsgpack 98.35% <100.00%> (?)
go-1.18 ?
go-1.19 ?
go-1.20 ?
go-1.21 ?
go-1.25 98.37% <100.00%> (?)
go-1.26 98.37% <100.00%> (?)
macos-latest 98.37% <100.00%> (-0.84%) ⬇️
ubuntu-latest 98.37% <100.00%> (-0.84%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant