Skip to content

adding check if char == '-', if so not using as modifier for keypress #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sheik wants to merge 2 commits into
base: main
Choose a base branch
from
Open

adding check if char == '-', if so not using as modifier for keypress #105

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb032a9
adding check if char == '-', if so not using as modifier
sheik Dec 8, 2022
226ba35
WIP
sheik Dec 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion io/key/key.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,11 @@ func (k Set) Contains(name string, mods Modifiers) bool {
var modSet, keySet string
sep := strings.LastIndex(chord, "-")
if sep != -1 {
modSet, keySet = chord[:sep], chord[sep+1:]
if chord == "-" {
modSet, keySet = "", chord
} else {
modSet, keySet = chord[:sep], chord[sep+1:]
}

@whereswaldon whereswaldon Dec 8, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps I am misreading, but this seems like it would only work to bind to literal presses of -. It doesn't handle modifier keys in combination with - such as Short-- or Ctrl--. Here's a playground demonstrating some of the failure cases. I think whatever we do needs to handle all of the ones I put in the playground, probably by detecting when the final character is - and doing special processing.

@sheik sheik Dec 8, 2022

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh good point. I will be implementing these in my app soon so I'll update the PR when I do so.

} else {
modSet, keySet = "", chord
}
Expand Down