Refactor getfeatures and getlist#932
Open
smaspons wants to merge 1 commit into
Open
Conversation
sysType API contract. Extract filter, list-resolution, and canvas SQL into typed helpers so getlist and getfeatures share one implementation. Slim down getfeatures, route tableName through config_form_list, and keep legacy sysType calls (e.g. PIPE) on ve_node/ve_arc for existing API consumers.
danimarinBG
reviewed
Jun 25, 2026
Contributor
There was a problem hiding this comment.
Don't modify this file — you should add it directly to patch.sql instead.
danimarinBG
reviewed
Jun 25, 2026
danimarinBG
requested changes
Jun 25, 2026
danimarinBG
left a comment
danimarinBG
left a comment
Contributor
There was a problem hiding this comment.
Also, it would be great if all the tests passed, and if you could create new ones for these new features, that would be perfect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract filter, list-resolution, and canvas SQL into typed helpers so getlist and getfeatures share one implementation. Slim down getfeatures, route tableName through config_form_list, and keep legacy sysType calls (e.g. PIPE) on ve_node/ve_arc for existing API consumers.