feat(agent): add per-port FEC configuration knobs#1394
Conversation
There was a problem hiding this comment.
Copilot reviewed 32 out of 32 changed files in this pull request and generated no comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🚀 Temp artifacts published: |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 32 out of 32 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
edipascale
force-pushed
the
ema/interface-fec
branch
from
143b240 to
e6cdcb8
Compare
|
🚀 Temp artifacts published: |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 32 out of 32 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
edipascale
force-pushed
the
ema/interface-fec
branch
from
e6cdcb8 to
fef6a19
Compare
|
🚀 Temp artifacts published: |
|
From sprint plan: We need to confirm whether we actually want this |
edipascale
force-pushed
the
ema/interface-fec
branch
2 times, most recently
from
ebb77a9 to
534f6e8
Compare
|
🚀 Temp artifacts published: |
edipascale
force-pushed
the
ema/interface-fec
branch
from
534f6e8 to
d0b0170
Compare
|
🚀 Temp artifacts published: |
Add PortFECs map[string]PortFECMode to SwitchSpec, mirroring the PortAutoNegs pattern. Supported modes: rs, fc, auto, disabled. Only ports that are explicitly configured by the user are managed by the agent. Removing the relevant config from the switch spec does NOT reset the FEC value on the port; the ideal action would be to set it to DEFAULT, but that value is then translated to something else depending on a number of factors (i.e. port speed/ breakout mode, auto neg setting), and the config diff would never be resolved. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Emanuele Di Pascale <emanuele@githedgehog.com>
edipascale
force-pushed
the
ema/interface-fec
branch
from
d0b0170 to
8a9e711
Compare
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
🚀 Temp artifacts published: |
1 similar comment
|
🚀 Temp artifacts published: |
Add PortFECs map[string]PortFECMode to SwitchSpec, mirroring the PortAutoNegs pattern. Supported modes: rs, fc, auto, disabled.
FEC defaults follow Broadcom SONiC rules: FEC RS is applied by default on 1x400G, 2x400G, 1x200G, 2x200G, and 4x100G breakout modes; all other ports default to FEC disabled. Defaults are encoded per breakout mode in SwitchProfilePortProfileBreakoutMode.FECDefault, with a profile-level FECDefault as fallback for speed-type profiles.
planPortFECs always sets an explicit FEC value (never UNSET/DEFAULT), consistent with observed Broadcom SONiC behaviour. FEC is applied via the existing specInterfaceEthernetBaseEnforcer using the PortFec field already present in the OpenConfig bindings.
Fix https://github.com/githedgehog/internal/issues/350