build(deps): bump github.com/go-chi/chi/v5 from 5.2.5 to 5.3.0#1463
Conversation
81871c9 to
4e41347
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (15)
💤 Files with no reviewable changes (2)
✅ Files skipped from review due to trivial changes (3)
🚧 Files skipped from review as they are similar to previous changes (9)
📝 WalkthroughWalkthroughchi HTTP router library updated to v5.3.0 with new client IP extraction middlewares supporting header-based and X-Forwarded-For traversal with CIDR validation. Logger middleware now integrates the new client IP functions. Router pattern handling simplified for Go 1.23+. Documentation expanded; RealIP marked deprecated. Changeschi v5.3.0 Upgrade
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@vendor/github.com/go-chi/chi/v5/README.md`:
- Around line 382-387: The README links for ClientIPFromHeader, ClientIPFromXFF,
ClientIPFromXFFTrustedProxies, ClientIPFromRemoteAddr, GetClientIP and
GetClientIPAddr point to github.com/go-chi/chi/middleware but these symbols live
under the v5 module path; update each pkg.go.dev URL in
vendor/github.com/go-chi/chi/v5/README.md to include /v5/ (e.g. change
.../github.com/go-chi/chi/middleware#... to
.../github.com/go-chi/chi/v5/middleware#...) so the anchors resolve to the
correct v5 documentation for the listed symbols.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 141a629b-fba5-41c8-a3dc-530789b3df6f
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (13)
go.modvendor/github.com/go-chi/chi/v5/README.mdvendor/github.com/go-chi/chi/v5/chi.govendor/github.com/go-chi/chi/v5/middleware/client_ip.govendor/github.com/go-chi/chi/v5/middleware/compress.govendor/github.com/go-chi/chi/v5/middleware/logger.govendor/github.com/go-chi/chi/v5/middleware/realip.govendor/github.com/go-chi/chi/v5/middleware/wrap_writer.govendor/github.com/go-chi/chi/v5/mux.govendor/github.com/go-chi/chi/v5/pattern.govendor/github.com/go-chi/chi/v5/pattern_fallback.govendor/github.com/go-chi/chi/v5/tree.govendor/modules.txt
💤 Files with no reviewable changes (2)
- vendor/github.com/go-chi/chi/v5/pattern_fallback.go
- vendor/github.com/go-chi/chi/v5/pattern.go
4e41347 to
aa18de8
Compare
aa18de8 to
e25214b
Compare
Bumps [github.com/go-chi/chi/v5](https://github.com/go-chi/chi) from 5.2.5 to 5.3.0. - [Release notes](https://github.com/go-chi/chi/releases) - [Changelog](https://github.com/go-chi/chi/blob/master/CHANGELOG.md) - [Commits](go-chi/chi@v5.2.5...v5.3.0) --- updated-dependencies: - dependency-name: github.com/go-chi/chi/v5 dependency-version: 5.3.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Sergei Lukianov <me@slukjanov.name>
e25214b to
070195d
Compare
chi 5.3.0 deprecated RealIP for IP-spoofing reasons. The boot server binds directly to ControlVIP with no proxy in front, so use ClientIPFromRemoteAddr and read the client IP via GetClientIP in the request logger. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Sergei Lukianov <me@slukjanov.name>
070195d to
fca3f7a
Compare
|
🚀 Temp artifacts published: |
Bumps github.com/go-chi/chi/v5 from 5.2.5 to 5.3.0.
Release notes
Sourced from github.com/go-chi/chi/v5's releases.
... (truncated)
Commits
3b17157feat: middleware.ClientIP, a replacement for middleware.RealIP (#967)818fdcffix: set Request.Pattern from RoutePattern() (#1097)f975af0Fix typo in Route doc comment (#1073)4ef87eamiddleware: fix httpFancyWriter.ReadFrom double-counting bytes with Tee (#1085)a54874fBump minimum Go to 1.23, always use request.Pattern (#1048)3328d4dApply the stringscutprefix modernizer (#1051)be60b2eSimplify chi.walk with slices.Concat (#1053)a36a925Remove last uses of io/ioutil (#1054)7d93ee3add go 1.26 to ci (#1052)903cff2Propagate inline middlewares across mounted subrouters (#1049)