Skip to content

Show star ratings on game cards #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tbdumpacc777-prog wants to merge 2 commits into
base: main
Choose a base branch
from
+16 −0
Open

Show star ratings on game cards #73

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31f8325
Show ratings on game cards
tbdumpacc777-prog Sep 3, 2026
4a3a9c6
Test every game card rating
tbdumpacc777-prog Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions e2e-tests/games.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,12 @@ test.describe('Game Listing and Navigation', () => {
await expect(gameCards.first().getByTestId('game-title')).toBeVisible();
await expect(gameCards.first().getByTestId('game-title')).not.toBeEmpty();
});

await test.step('Verify every game card has a rating', async () => {
const gameCards = page.getByTestId('game-card');
await expect(page.getByTestId('game-rating')).toHaveCount(await gameCards.count());
await expect(gameCards.first().getByTestId('game-rating')).not.toBeEmpty();
});
Comment thread
tbdumpacc777-prog marked this conversation as resolved.
});

test('should navigate to correct game details page when clicking on a game', async ({ page }) => {
Expand Down
6 changes: 6 additions & 0 deletions src/components/GameCard.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
---
import type { Game } from '../types/game';
import Tag from './Tag.astro';
import StarRating from './StarRating.astro';
import ArrowRight from '../assets/icons/arrow-right.svg';

interface Props {
Expand Down Expand Up @@ -37,6 +38,11 @@ const { game } = Astro.props;
</div>
)}

{game.starRating === null
? <p class="text-sm text-slate-400" data-testid="game-rating">No rating yet</p>
: <StarRating rating={game.starRating} />
}

<p class="text-slate-400 mb-4 text-sm line-clamp-2" data-testid="game-description">{game.description}</p>

<div class="mt-4 text-sm text-blue-400 font-medium flex items-center">
Expand Down