Skip to content

Scan additional pages per static site - #39

Merged
taarikashenafi merged 2 commits into
mainfrom
taarikashenafi/scan-more-pages-per-site
Jun 22, 2026
Merged

taarikashenafi merged 2 commits into
mainfrom
taarikashenafi/scan-more-pages-per-site

Conversation

@taarikashenafi

Copy link
Copy Markdown
Contributor

Expands each site in the scan-static-sites matrix to scan several representative pages instead of only the landing page, per mentor feedback that the scanner only hits explicitly-listed URLs.

  • Uses the scanner's urls input to list multiple pages per site.
  • Universe, Shop, and Blog now include a handful of high-traffic subpages; Octodex remains single-page (it's a one-page gallery).
  • Routing unchanged: all findings still go to github/accessibility-scanner-testing, and skip_copilot_assignment: true is retained — no teams pinged.
  • fail-fast: false keeps each site isolated, so a single unreachable URL won't break the run.

Copilot AI review requested due to automatic review settings June 22, 2026 17:25
@taarikashenafi
taarikashenafi requested a review from a team as a code owner June 22, 2026 17:25
GitHub Advanced Security started work on behalf of taarikashenafi June 22, 2026 17:25
GitHub Advanced Security finished work on behalf of taarikashenafi June 22, 2026 17:26

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Ready to approve

The change is a straightforward workflow matrix expansion that aligns with existing documented usage of the scanner’s urls input and does not alter routing or scan configuration.

Note: this review does not count toward required approvals for merging.

Pull request overview

This PR expands the scan-static-sites workflow matrix so each static site scan can cover multiple representative URLs (not just the landing page), improving coverage for the alt-text plugin scans while keeping routing and isolation behavior consistent.

Changes:

  • Converted the urls matrix value from a single URL string to a multi-line urls: | block for each site.
  • Added several high-traffic subpages for Universe, Shop, and Blog while leaving Octodex as a single URL.
File summaries
File Description
.github/workflows/scan-static-sites.yml Updates the scan matrix to pass multiple URLs per site into the accessibility scanner action for broader coverage.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

Note

Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@taarikashenafi
taarikashenafi requested a review from JoyceZhu June 22, 2026 17:28
- id: octodex
urls: https://octodex.github.com/
urls: |
https://octodex.github.com/

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be worth picking another subpage (like https://octodex.github.com/bombacat/) -- although this website's pretty simple compared to the other static ones, this does check a different surface area than the homepage with a grid of Octocats.

JoyceZhu
JoyceZhu previously approved these changes Jun 22, 2026
@taarikashenafi
taarikashenafi merged commit 6f01cb3 into main Jun 22, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants