Skip to content

Go: Update to 1.27 #22042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jketema merged 8 commits into from
Aug 20, 2026
Merged

Go: Update to 1.27 #22042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
50455bd
Go: Update to 1.27
jketema Jun 24, 2026
3dfe5e6
Go: Bump `maxGoVersion` to 1.27
jketema Jun 24, 2026
f404c6a
Go: Update test formatting
jketema Jun 24, 2026
3185185
Go: Add change note
jketema Jun 24, 2026
777c089
Go: Update supported versions to include 1.27
jketema Jun 24, 2026
9db5585
Go: Fix `findMethodOnTypeWithGivenReceiver` for Go 1.27
jketema Jun 24, 2026
28d44f7
Go: Add generic method test
jketema Jun 30, 2026
072b298
Go: Fix crash in `getTypeParamParentLabel`
jketema Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ use_repo(
)

go_sdk = use_extension("@rules_go//go:extensions.bzl", "go_sdk")
go_sdk.download(version = "1.26.6")
go_sdk.download(version = "1.27.0")

go_deps = use_extension("@gazelle//:extensions.bzl", "go_deps")
go_deps.from_file(go_mod = "//go/extractor:go.mod")
Expand Down
2 changes: 1 addition & 1 deletion docs/codeql/reusables/supported-versions-compilers.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

.NET 5, .NET 6, .NET 7, .NET 8, .NET 9, .NET 10","``.sln``, ``.slnx``, ``.csproj``, ``.cs``, ``.cshtml``, ``.xaml``"
GitHub Actions,"Not applicable",Not applicable,"``.github/workflows/*.yml``, ``.github/workflows/*.yaml``, ``**/action.yml``, ``**/action.yaml``"
Go (aka Golang), "Go up to 1.26", "Go 1.11 or more recent", ``.go``
Go (aka Golang), "Go up to 1.27", "Go 1.11 or more recent", ``.go``
Java,"Java 7 to 26 [5]_","javac (OpenJDK and Oracle JDK),

Eclipse compiler for Java (ECJ) [6]_",``.java``
Expand Down
2 changes: 1 addition & 1 deletion go/actions/test/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ inputs:
go-test-version:
description: Which Go version to use for running the tests
required: false
default: "~1.26.6"
default: "~1.27.0"
run-code-checks:
description: Whether to run qhelp generation checks
required: false
Expand Down
2 changes: 1 addition & 1 deletion go/extractor/autobuilder/build-environment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import (
)

var minGoVersion = util.NewSemVer("1.11")
var maxGoVersion = util.NewSemVer("1.26")
var maxGoVersion = util.NewSemVer("1.27")

type versionInfo struct {
goModVersion util.SemVer // The version of Go found in the go directive in the `go.mod` file.
Expand Down
24 changes: 23 additions & 1 deletion go/extractor/extractor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1657,8 +1657,30 @@ func extractType(tw *trap.Writer, tp types.Type) trap.Label {
// parent scope, so they are not dealt with by `extractScopes`
for i := 0; i < origintp.NumMethods(); i++ {
meth := origintp.Method(i).Origin()

extractMethod(tw, meth)

// Consider a generic struct and a generic method:
//
// type S[P any] struct{}
// func (*S[P]) m[Q any](x Q) {}
//
// If we have a variable 's' of type 'S[int]' and the expression
// 's.m[string]("")', then the type of the selector expression 's.m'
// is ' func(Q)'. The method 'm' here is an instantiation of the
// declaration, which has its own type with type parameter 'Q'.
// As we do not extract method instantiations, 'populateTypeParamParents'
// does not automatically get called for the type parameter 'Q'
// from the instantiation of 'm'. To compensate, we add the type
// parameters here.
//
// As a parent we use the origin method. This suffices, as the name
// and index of the type parameter in the instantiation will be
// identical to those of the uninstantiated method, and as only
// these two properties will be extracted for a type parameter.
if tp.Method(i) != meth {
signature := tp.Method(i).Type().(*types.Signature)
populateTypeParamParents(signature.TypeParams(), meth, false)
}
Comment on lines +1676 to +1683

@jketema jketema Aug 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is indeed an issues here. Consider the following:

type StructWithDependentBound[P any] struct{}

func (*StructWithDependentBound[P]) GenericMethodWithDependentBound[Q ~[]P](x Q) {}

func genericMethodDependentBounds(
	withInt StructWithDependentBound[int],
	withString StructWithDependentBound[string],
) {
	withInt.GenericMethodWithDependentBound([]int{})
	withString.GenericMethodWithDependentBound([]string{})
}

then

from TypeParamType parameter
select parameter.getParamName(), parameter.getConstraint().pp()

produces:

| P | interface { } |
| Q | interface { ~[]P } |
| Q | interface { ~[]int } |
| Q | interface { ~[]string } |

and there are dataset check errors:

[INVALID_KEY_SET] predicate typeparam(@typeparamtype tp, string name, @compositetype bound, @typeparamparentobject parent, int idx, boolean is_from_recv): The key set {parent, idx, is_from_recv} does not functionally determine all fields.
Here is a pair of tuples that agree on the key set but differ at index 2:
Tuple 1 in row 2: (81,"Q",87,52,0,false)
Tuple 2 in row 3: (81,"Q",155,52,0,false)
	Relevant element: tp=81
		Full ID for 81: @"(53),0,false,Q;typeparamtype". The ID may expand to @"{@"{@"{@"(50)"},GenericMethodWithDependentBound;method"}"},0,false,Q;typeparamtype"
	Relevant element: Tuple 1: bound=87
		Full ID for 87: @";(86);interfacetype". The ID may expand to @";{@"{@"~{@"(83)"};typesetliteraltype"}"};interfacetype"
	Relevant element: Tuple 2: bound=155
		Full ID for 155: @";(154);interfacetype". The ID may expand to @";{@"{@"~{@"(147)"};typesetliteraltype"}"};interfacetype"
	Relevant element: parent=52
		Full ID for 52: @"(51),GenericMethodWithDependentBound;method". The ID may expand to @"{@"{@"{@"(47)"};pointertype"}"},GenericMethodWithDependentBound;method"
[INVALID_KEY] predicate typeparam(@typeparamtype tp, string name, @compositetype bound, @typeparamparentobject parent, int idx, boolean is_from_recv): The key set {tp} does not functionally determine all fields.
Here is a pair of tuples that agree on the key set but differ at index 2:
Tuple 1 in row 2: (81,"Q",87,52,0,false)
Tuple 2 in row 3: (81,"Q",155,52,0,false)
	Relevant element: tp=81
		Full ID for 81: @"(53),0,false,Q;typeparamtype". The ID may expand to @"{@"{@"{@"(50)"},GenericMethodWithDependentBound;method"}"},0,false,Q;typeparamtype"
	Relevant element: Tuple 1: bound=87
		Full ID for 87: @";(86);interfacetype". The ID may expand to @";{@"{@"~{@"(83)"};typesetliteraltype"}"};interfacetype"
	Relevant element: Tuple 2: bound=155
		Full ID for 155: @";(154);interfacetype". The ID may expand to @";{@"{@"~{@"(147)"};typesetliteraltype"}"};interfacetype"
	Relevant element: parent=52
		Full ID for 52: @"(51),GenericMethodWithDependentBound;method". The ID may expand to @"{@"{@"{@"(47)"};pointertype"}"},GenericMethodWithDependentBound;method"

Copilot's proposed fix is not near being correct.

}

underlyingInterface, underlyingIsInterface := underlying.(*types.Interface)
Expand Down
4 changes: 2 additions & 2 deletions go/extractor/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
module github.com/github/codeql-go/extractor

go 1.26
go 1.27

toolchain go1.26.6
toolchain go1.27.0

// when updating this, run
// bazel run @rules_go//go -- mod tidy
Expand Down
6 changes: 3 additions & 3 deletions go/extractor/toolchain/toolchain_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ import (

func TestParseGoVersion(t *testing.T) {
tests := map[string]string{
"go version go1.18.9 linux/amd64": "go1.18.9",
"go version go1.26.3-X:nodwarf5 linux/amd64": "go1.26.3",
"go version go1.26.3rc1 linux/amd64": "go1.26.3rc1",
"go version go1.18.9 linux/amd64": "go1.18.9",
"go version go1.26.3-X:nodwarf5 linux/amd64": "go1.26.3",
"go version go1.26.3rc1 linux/amd64": "go1.26.3rc1",
"warning: GOPATH set to GOROOT (/usr/local/go) has no effect\ngo version go1.18.9 linux/amd64": "go1.18.9",
}
for input, expected := range tests {
Expand Down
2 changes: 1 addition & 1 deletion go/extractor/trap/labels.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ func findMethodOnTypeWithGivenReceiver(tp types.Type, object types.Object) *type
if definedType, ok := tp.(*types.Named); ok {
for i := 0; i < definedType.NumMethods(); i++ {
meth := definedType.Method(i)
if object == meth.Type().(*types.Signature).Recv() {
if object == meth.Type().(*types.Signature).Recv().Origin() {
return meth
}
}
Expand Down
4 changes: 4 additions & 0 deletions go/ql/lib/change-notes/2026-06-25-go-1.27.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: majorAnalysis
---
* Go 1.27 is now supported.
2 changes: 2 additions & 0 deletions go/ql/test/library-tests/semmle/go/Function/GenericFunctionInstantiationExpr.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,5 @@
| genericFunctions.go:45:6:45:50 | generic function instantiation expression | genericFunctions.go:45:6:45:33 | GenericFunctionTwoTypeParams | 1 | genericFunctions.go:45:43:45:49 | float64 |
| genericFunctions.go:141:6:141:41 | generic function instantiation expression | genericFunctions.go:141:6:141:33 | GenericFunctionInAnotherFile | 0 | genericFunctions.go:141:35:141:40 | string |
| genericFunctions.go:146:6:146:55 | generic function instantiation expression | genericFunctions.go:146:6:146:47 | selection of GenericFunctionInAnotherPackage | 0 | genericFunctions.go:146:49:146:54 | string |
| genericMethods.go:13:2:13:23 | generic function instantiation expression | genericMethods.go:13:2:13:18 | selection of GenericMethod1 | 0 | genericMethods.go:13:20:13:22 | int |
| genericMethods.go:14:2:14:26 | generic function instantiation expression | genericMethods.go:14:2:14:18 | selection of GenericMethod2 | 0 | genericMethods.go:14:20:14:25 | string |
7 changes: 7 additions & 0 deletions go/ql/test/library-tests/semmle/go/Function/TypeParamType.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ numberOfTypeParameters
| genericFunctions.go:150:6:150:36 | multipleAnonymousTypeParamsFunc | 3 |
| genericFunctions.go:152:6:152:36 | multipleAnonymousTypeParamsType | 3 |
| genericFunctions.go:154:51:154:51 | f | 3 |
| genericMethods.go:5:33:5:46 | GenericMethod1 | 1 |
| genericMethods.go:7:6:7:28 | StructForGenericMethod2 | 1 |
| genericMethods.go:9:37:9:50 | GenericMethod2 | 2 |
#select
| codeql-go-tests/function.EdgeConstraint | 0 | | Node | interface { } |
| codeql-go-tests/function.Element | 0 | | S | interface { } |
Expand All @@ -44,6 +47,10 @@ numberOfTypeParameters
| codeql-go-tests/function.New | 0 | | Node | NodeConstraint |
| codeql-go-tests/function.New | 1 | | Edge | EdgeConstraint |
| codeql-go-tests/function.NodeConstraint | 0 | | Edge | interface { } |
| codeql-go-tests/function.StructForGenericMethod1.GenericMethod1 | 0 | | P1 | interface { } |
| codeql-go-tests/function.StructForGenericMethod2 | 0 | | P2 | interface { } |
| codeql-go-tests/function.StructForGenericMethod2.GenericMethod2 | 0 | | P4 | interface { } |
| codeql-go-tests/function.StructForGenericMethod2.GenericMethod2 | 0 | from receiver | P3 | interface { } |
| codeql-go-tests/function.multipleAnonymousTypeParamsFunc | 0 | | _ | interface { } |
| codeql-go-tests/function.multipleAnonymousTypeParamsFunc | 1 | | _ | interface { string } |
| codeql-go-tests/function.multipleAnonymousTypeParamsFunc | 2 | | _ | interface { } |
Expand Down
19 changes: 19 additions & 0 deletions go/ql/test/library-tests/semmle/go/Function/genericMethods.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
package main

type StructForGenericMethod1 struct{}

func (*StructForGenericMethod1) GenericMethod1[P1 any](x P1) {}

type StructForGenericMethod2[P2 any] struct{}

func (*StructForGenericMethod2[P3]) GenericMethod2[P4 any](x P4) {}

func generic_methods(s1 StructForGenericMethod1, s2 StructForGenericMethod2[int]) {
// Call the generic method specifying the type
s1.GenericMethod1[int](1)
s2.GenericMethod2[string]("hello")

// Call the generic method without specifying the type
s1.GenericMethod1("hello")
s2.GenericMethod2(42)
}
4 changes: 4 additions & 0 deletions go/ql/test/library-tests/semmle/go/Function/getParameter.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@
| genericFunctions.go:138:29:138:40 | ShortestPath | 1 | genericFunctions.go:138:48:138:49 | to |
| genericFunctions.go:138:29:138:40 | ShortestPath | -1 | genericFunctions.go:138:7:138:7 | g |
| genericFunctions.go:154:51:154:51 | f | -1 | genericFunctions.go:154:7:154:7 | x |
| genericMethods.go:5:33:5:46 | GenericMethod1 | 0 | genericMethods.go:5:56:5:56 | x |
| genericMethods.go:9:37:9:50 | GenericMethod2 | 0 | genericMethods.go:9:60:9:60 | x |
| genericMethods.go:11:6:11:20 | generic_methods | 0 | genericMethods.go:11:22:11:23 | s1 |
| genericMethods.go:11:6:11:20 | generic_methods | 1 | genericMethods.go:11:50:11:51 | s2 |
| main.go:7:6:7:7 | f1 | 0 | main.go:7:9:7:9 | x |
| main.go:9:12:9:13 | f2 | 0 | main.go:9:15:9:15 | x |
| main.go:9:12:9:13 | f2 | 1 | main.go:9:18:9:18 | y |
Expand Down
3 changes: 3 additions & 0 deletions go/ql/test/library-tests/semmle/go/Function/getTypeParameter.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,6 @@
| genericFunctions.go:152:6:152:69 | type declaration specifier | TypeSpec | 0 | genericFunctions.go:152:38:152:42 | type parameter declaration | 0 | genericFunctions.go:152:38:152:38 | _ | genericFunctions.go:152:40:152:42 | any | interface { } |
| genericFunctions.go:152:6:152:69 | type declaration specifier | TypeSpec | 1 | genericFunctions.go:152:45:152:52 | type parameter declaration | 0 | genericFunctions.go:152:45:152:45 | _ | genericFunctions.go:152:47:152:52 | string | interface { string } |
| genericFunctions.go:152:6:152:69 | type declaration specifier | TypeSpec | 2 | genericFunctions.go:152:55:152:59 | type parameter declaration | 0 | genericFunctions.go:152:55:152:55 | _ | genericFunctions.go:152:57:152:59 | any | interface { } |
| genericMethods.go:5:1:5:63 | function declaration | MethodDecl | 0 | genericMethods.go:5:48:5:53 | type parameter declaration | 0 | genericMethods.go:5:48:5:49 | P1 | genericMethods.go:5:51:5:53 | any | interface { } |
| genericMethods.go:7:6:7:45 | type declaration specifier | TypeSpec | 0 | genericMethods.go:7:30:7:35 | type parameter declaration | 0 | genericMethods.go:7:30:7:31 | P2 | genericMethods.go:7:33:7:35 | any | interface { } |
| genericMethods.go:9:1:9:67 | function declaration | MethodDecl | 0 | genericMethods.go:9:52:9:57 | type parameter declaration | 0 | genericMethods.go:9:52:9:53 | P4 | genericMethods.go:9:55:9:57 | any | interface { } |
2 changes: 1 addition & 1 deletion go/ql/test/library-tests/semmle/go/Function/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module codeql-go-tests/function

go 1.18
go 1.27

require github.com/anotherpkg v0.0.0-20200203000000-0000000000000

Loading