-
Notifications
You must be signed in to change notification settings - Fork 2.1k
C++: Add ECMAScript std::regex parser
#22300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jketema
wants to merge
40
commits into
github:main
Choose a base branch
from
jketema:jketema/ecma-regex
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,382
−0
Open
Changes from 14 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
7f959bf
C++: Copy Ruby regex library and tests verbatim
Copilot 4096725
C++: Make regex library compile
jketema cc4f5bd
C++: Make regex test work
jketema d5d73f6
C++: Add location tests for all literal prefixes
Copilot 322c1c0
C++: Add `RawStringLiteral` class
jketema fd929e2
C++: Fix regex starting location
jketema eb53e56
C++: Remove Ruby-only \A/\Z/\z/\G anchors from regex grammar
Copilot 6e71f00
C++: Remove Ruby-only \h and \H character class escapes
Copilot a471af9
C++: Remove Ruby-style \p and \P named character properties
jketema c3fd966
C++: Remove Ruby-style (?#...) comment groups
Copilot b2d0766
C++: Remove single-quote named capture groups
Copilot 985a2ba
C++: Remove named capture groups
Copilot bb96e90
C++: Remove named backreferences
Copilot da931e4
C++: Remove lookbehind assertions
Copilot 0a3887d
C++: Remove {,m} quantifier form
jketema 64a9a75
C++: Remove inverted named character properties
jketema 24251de
C++: Add control-escape tests (pre-fix)
Copilot 8d45199
C++: Implement \cX control escapes
Copilot 87cdedd
C++: Add NUL-escape tests (pre-fix)
Copilot 81783e6
C++: Implement \0 NUL escape
Copilot 03625be
C++: Add POSIX collating-symbol tests (pre-fix)
Copilot 32e3a11
C++: Fix typo
jketema 57f5d03
C++: Implement POSIX collating symbols
jketema 96c9214
C++: Add POSIX equivalence-class tests (pre-fix)
Copilot 5cce52e
C++: Implement POSIX equivalence classes
jketema b1e7fb7
C++: Replace non-standard \u{...} test with \uhhhh
Copilot f7797ed
C++: Add coverage for lazy quantifiers and \f/\v escapes
Copilot 009ae43
C++: Verify [\b] is backspace inside character classes
Copilot 66c191a
C++: Add change note for std::regex ECMAScript parser alignment
Copilot b2fc6a1
C++: Drop unneeded `\U` from `isUnicode`
jketema aa14162
C++: add hex escape test
jketema ff038a2
C++: Handle `\0` in `RegExpEscape`
jketema 40feb22
C++: Handle `\cX` in `RegExpEscape` and slightly tweak test
jketema e6cfe17
C++: Handle `\xhh` in `RegExpEscape`
jketema b30d9d6
C++: Fix change note category
jketema aca8aa9
C++: Fix off-by-one in `\cX` handling
jketema e95ae40
C++: Fix QL-for-QL errors
jketema 8a41ec0
C++: Add `RegExpNamedCharacterProperty` subclasses
jketema fbd8737
Fix typo
jketema b15082f
Fix typo
jketema File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be nice to have a test for
RawStringLiteralitself, even if it's just a very basic test as part of the regex tests e.g.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. Will add.