-
Notifications
You must be signed in to change notification settings - Fork 9.6k
feat(workflows): add JSON output for workflow run resume and status #2814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
doquanghuy
wants to merge
5
commits into
github:main
Choose a base branch
from
doquanghuy:feat/2811-workflow-json
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+293
−6
Open
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
94f33e6
feat(workflows): add --json output to workflow run, resume, and status
doquanghuy 60f36d4
Merge remote-tracking branch 'upstream/main' into feat/2811-workflow-…
doquanghuy abfa237
fix(workflows): keep --json stdout clean while steps write output
doquanghuy ea95653
docs(workflows): fix stray escape sequence in --json redirect comments
doquanghuy 9575f2a
Merge remote-tracking branch 'upstream/main' into feat/2811-workflow-…
doquanghuy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch — fixed in abfa237. While
--jsonis active,engine.execute()/engine.resume()now run inside a file-descriptor-level redirect (dup2of fd 1 → fd 2), so both Python-level writes (the gate prompt) and inherited-fd subprocess output (the prompt step's CLI) land on stderr while stdout carries only the JSON object. Step progress stays visible on stderr;statusdoesn't run the engine, so it's unaffected. Added tests that exercise both pollution channels (a Pythonprintand a real subprocess) via fd-level capture, plus the inactive no-op path, and documented the stdout/stderr split.