fixed compilation for custom Qt namespace#851
Merged
Conversation
Owner
|
Out of pure curiosity, what is the advantage of a custom Qt namespace? |
Author
|
If you have eg. Qt5.8 installed in the system, but application has 5.11 then it is less likely to have conflicts. The same if application allows user to load their code dynamically. We already had a problem that their code was linked to different version of Qt. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a custom Qt namespace and in order to compile this project I had to make some simple changes in forward declarations of Qt classes.