Skip to content

Feature/1164#1165

Open
DominikLudwiczak wants to merge 11 commits into
gitroomhq:mainfrom
DominikLudwiczak:feature/1055
Open

Feature/1164#1165
DominikLudwiczak wants to merge 11 commits into
gitroomhq:mainfrom
DominikLudwiczak:feature/1055

Conversation

@DominikLudwiczak
Copy link
Copy Markdown

What kind of change does this PR introduce?

applies password change feature

Why was this change needed?

#1164

Other information:

Checklist:

Put a "X" in the boxes below to indicate you have followed the checklist;

  • [ x] I have read the CONTRIBUTING guide.
  • [ x] I checked that there were not similar issues or PRs already open for this.
  • [ x] This PR fixes just ONE issue (do not include multiple issues or types of change in the same PR) For example, don't try and fix a UI issue and include new dependencies in the same PR.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 11, 2026

@DominikLudwiczak is attempting to deploy a commit to the Listinai Team on Vercel.

A member of the Team first needs to authorize it.

import { AddTeamMemberDto } from '@gitroom/nestjs-libraries/dtos/settings/add.team.member.dto';
import { ApiTags } from '@nestjs/swagger';
import { AuthorizationActions, Sections } from '@gitroom/backend/services/auth/permissions/permission.exception.class';
import { User } from 'facebook-nodejs-business-sdk';

This comment was marked as outdated.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, I pushed change

@Body() body: ChangePasswordDto
) {
const userWithPassword = await this._userService.getUserById(user.id);
if(!userWithPassword || !AuthChecker.comparePassword(body.oldPassword, userWithPassword.password)) {

This comment was marked as outdated.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, changed it and also in setting tab on frontend part I added condition that only LOCAL users can see change password tab

Comment on lines +60 to +64
const userWithPassword = await this._userService.getUserById(user.id);
if(userWithPassword.providerName !== 'LOCAL') {
return false;
}
if(!userWithPassword || !AuthChecker.comparePassword(body.oldPassword, userWithPassword.password)) {

This comment was marked as outdated.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@Controller('/auth')
export class AuthController {
constructor(
constructor(
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't modify any files unrelated to this PR.

Comment thread .github/Dependabot.yml
directory: "/" # Location of package manifests
schedule:
interval: "daily"
interval: "weekly"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't modify any files unrelated to this PR.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

This PR is stale because it has been open for 90 days with no activity.

@github-actions github-actions Bot added the stale label Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants