Skip to content

Add PageTitle field for Title fallback in change detection #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
panitan103 wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Add PageTitle field for Title fallback in change detection #984

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c5b7a3
Update docs
svilenmarkov Dec 10, 2025
9b580fe
feat(widget): add PageTitle field to changeDetectionResponseJson for …
panitan103 Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/configuration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,14 +149,14 @@ pages:
columns:
- size: full
widgets:
$include: rss.yml
- $include: rss.yml
- name: News
columns:
- size: full
widgets:
- type: group
widgets:
$include: rss.yml
- $include: rss.yml
- type: reddit
subreddit: news
```
Expand Down
3 changes: 3 additions & 0 deletions internal/glance/widget-changedetection.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ func (r changeDetectionWatchList) sortByNewest() changeDetectionWatchList {

type changeDetectionResponseJson struct {
Title string `json:"title"`
PageTitle string `json:"page_title"`
URL string `json:"url"`
LastChanged int64 `json:"last_changed"`
DateCreated int64 `json:"date_created"`
Expand Down Expand Up @@ -166,6 +167,8 @@ func fetchWatchesFromChangeDetection(instanceURL string, requestedWatchIDs []str

if watchJson.Title != "" {
watch.Title = watchJson.Title
} else if watchJson.PageTitle != "" {
watch.Title = watchJson.PageTitle
} else {
watch.Title = strings.TrimPrefix(strings.Trim(stripURLScheme(watchJson.URL), "/"), "www.")
}
Expand Down