Boundary condition refactor - multi-column FATES MVP#36
Draft
glemieux wants to merge 34 commits into
Draft
Conversation
glemieux
changed the title
glemieux
changed the title
glemieux
force-pushed
the
bc-refactor-mcf-mvp
branch
from
55baa82 to
595fc07
Compare
glemieux
force-pushed
the
bc-refactor-mcf-mvp
branch
4 times, most recently
from
9e56fa9 to
7ed3c27
Compare
glemieux
force-pushed
the
bc-refactor-mcf-mvp
branch
2 times, most recently
from
9636ede to
5b15606
Compare
glemieux
force-pushed
the
bc-refactor-mcf-mvp
branch
3 times, most recently
from
3ec6b3b to
313d24c
Compare
glemieux
force-pushed
the
bc-refactor-mcf-mvp
branch
from
313d24c to
f9c9321
Compare
glemieux
force-pushed
the
bc-refactor-mcf-mvp
branch
2 times, most recently
from
088b6a5 to
acd2ede
Compare
glemieux
force-pushed
the
bc-refactor-mcf-mvp
branch
from
fb1b137 to
2dd44fb
Compare
glemieux
force-pushed
the
bc-refactor-mcf-mvp
branch
from
2dd44fb to
a04719f
Compare
glemieux
force-pushed
the
bc-refactor-mcf-mvp
branch
4 times, most recently
from
3583b70 to
49df997
Compare
This should have its own filter or be merged into the existing litter flux in the future Co-authored-by: Copilot <copilot@github.com>
This removes the _si suffix as well
Addresses issue NGEET#1470
Now that overriding the soil temperature is handled locally, we can directly use tempk_sl where t_soisno_sl was previously used.
note that this boundary condition is currently not used in the code
These both reference watsat_col in the hlm
glemieux
force-pushed
the
bc-refactor-mcf-mvp
branch
from
6de44a7 to
84a7786
Compare
glemieux
force-pushed
the
bc-refactor-mcf-mvp
branch
from
84a7786 to
ca12ac4
Compare
glemieux
force-pushed
the
bc-refactor-mcf-mvp
branch
from
ca12ac4 to
882b625
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft is for visualization purposes to review the differences between NGEET#1477 and this branch. A new PR will be created on the NGEET fates repo.
The associated glemieux/E3SM pull request is here: glemieux/E3SM#39
Description:
Collaborators:
Expectation of Answer Changes:
Description of generative AI usage (as necessary)
Checklist
If this is your first time contributing, please read the CONTRIBUTING document.
All checklist items must be checked to enable merging this pull request:
Contributor
Integrator
If satellite phenology regressions are not b4b, please hold merge and notify the FATES development team.
Documentation
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: