Spherical cell list#313
Open
mthran wants to merge 11 commits into
Open
Conversation
… for Spherical<N>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces methods and traits necessary to implement cell lists and
ParallelSweepforSphericalsimulations:SphericalVecCellis implemented whose structure is almost identical to the already existingVecCell. Most of the methods and functionality are identical becauseSpherical<N>is embedded in N-dimensional Euclidean space. The search radii forSphericalVecCellmay be specified either using theSphericalgeodesic metric or through the Euclidean metric in the embedding space.vec_cell.rswhich were previously private have been promoted topub(crate)so as to avoid duplicate code inspherical_vec_cell.rs.ClosedSpherical<N>which implementsCover<Spherical<N>>is introduced. This is distinct from the pre-existingClosed<T>boundary because the latter implements methods such asScaleandVolumewhich are irrelevant and potentially misleading inSpherical<N>simulations.Motivation and context
This PR significantly improves the speed of
Spherical<N>simulations, which previously were too slow to run production simulations.How has this been tested?
spherical_vec_cell.rscontains unit tests for the methods which are unique to itself. I have also run simulations forSpherical<3>andSpherical<4>using the new methods and verified that they are consistent with older simulations usingAllPairs.Checklist:
doc/src/credits.md) in the pull request source branch.release-notes.mdfollowing the established format.