KB perf "quick wins" - #25247
Merged
trasher merged 5 commits intoAug 25, 2026
Merged
Conversation
Reading the full table and filtering in PHP is quicker here.
AdrienClairembault
marked this pull request as ready for review
August 24, 2026 14:16
trasher
reviewed
Aug 24, 2026
| 'knowbaseitems_id_parent' => $visible_ids, | ||
| ], | ||
| ]) as $link) { | ||
| foreach ($DB->request(['FROM' => KnowbaseItem_KnowbaseItem::getTable()]) as $link) { |
Contributor
There was a problem hiding this comment.
Suggested change
| foreach ($DB->request(['FROM' => KnowbaseItem_KnowbaseItem::getTable()]) as $link) { | |
| $links = $DB->request(['FROM' => KnowbaseItem_KnowbaseItem::getTable()]); | |
| foreach ($links as $link) { |
Member
Author
There was a problem hiding this comment.
What's wrong with this?
Contributor
There was a problem hiding this comment.
It's far better for performances to not call "costly" methods in a foreach loop
trasher
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small KB changes that do not impact any features and improved a bit performances and memory usage.