Skip to content

section name for imported libraries #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
safirex wants to merge 5 commits into
base: master
Choose a base branch
from
Open

section name for imported libraries #277

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c66d969
add library name as section name for user imported libraries
safirex Jun 3, 2020
914d85a
taking possible errors into account
safirex Mar 23, 2021
0824915
Merge branch 'master' into master
safirex Mar 23, 2021
9ad272a
move sectionName creation to function
safirex Apr 2, 2021
1044fbf
updating license year
safirex Apr 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion kit/src/main/java/com/oracle/javafx/scenebuilder/kit/library/user/LibraryFolderWatcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,8 +438,15 @@ private Collection<LibraryItem> makeLibraryItems(JarReport jarOrFolderReport) th
if (!excludedItems.contains(canonicalName) &&
!artifactsFilter.contains(canonicalName)) {
final String name = e.getKlass().getSimpleName();
String sectionName;
try{
Comment thread
abhinayagarwal marked this conversation as resolved.
Outdated
sectionName=jarOrFolderReport.getJar().toFile().getName().replace(".jar", "");
}catch(Exception exception){
Comment thread
abhinayagarwal marked this conversation as resolved.
Outdated
//if getJar returns null or toFile not finding path
sectionName=UserLibrary.TAG_USER_DEFINED;
}
Comment thread
safirex marked this conversation as resolved.
Outdated
final String fxmlText = BuiltinLibrary.makeFxmlText(e.getKlass());
result.add(new LibraryItem(name, UserLibrary.TAG_USER_DEFINED, fxmlText, iconURL, library));
result.add(new LibraryItem(name, sectionName, fxmlText, iconURL, library));
}
}
}
Expand Down