fix: SceneBuilder will not load missing files from recent projects. by Oliver-Loeffler · Pull Request #585 · gluonhq/scenebuilder

Oliver-Loeffler · 2022-10-10T21:47:30Z

Scene Builder will ask to remove missing files from recent files list.
Welcome Page will not close, there will not be an error message.

Issue

Fixes #582

Progress

Change must not contain extraneous whitespace
License header year is updated, if required
The PR name must follow the pre-defined format
Verify the contributor has signed Gluon Individual Contributor License Agreement (CLA)

Oliver-Loeffler · 2022-10-10T22:01:03Z

Bildschirmaufnahme.2022-10-10.um.23.58.04-1.mov

Window positioning is not yet okay. I am hesitating to touch the AlertDialog for this. Something like positionCentralOver or so could be helpful.

abhinayagarwal · 2022-11-08T07:42:24Z

The new tests added to the app project doesn't seem to run.

Oliver-Loeffler · 2022-11-08T16:14:48Z

I've moved the surefire-plugin from kit/POM.xml to POM.xml so that now tests of app and kit are executed during Maven build.

…nt projects. gluonhq#582

Co-authored-by: Oliver-Loeffler <Oliver-Loeffler@users.noreply.github.com>

… eventually tests are also picked up for app module.

Co-authored-by: Oliver-Loeffler <Oliver-Loeffler@users.noreply.github.com>

…welcome page in oder to have correct file name rendering for filenames with underscores. (gluonhq#578) Co-authored-by: Oliver-Loeffler <Oliver-Loeffler@users.noreply.github.com>

… confirming the error dialog.

Oliver-Loeffler · 2022-11-08T16:34:53Z

This PR now additionally addresses issue #600 which describes the behavior of unintended closing of SceneBuilder.

Oliver-Loeffler · 2022-12-11T18:05:40Z

Hi @abhinayagarwal, I have now corrected the POM for app. Tests are running now. Could you please review this one again?

Oliver-Loeffler · 2022-12-11T18:42:24Z

@AlmasB Hi Almas, may be you also could have a look on this one!

…m recent items and for cases where errors occured during FXML loading.

Oliver-Loeffler · 2023-01-03T21:10:51Z

Happy new year SceneBuilder!
Hope you'll had a good start into 2023.

@abhinayagarwal, could you please review this one again? The tests are now triggered properly.

abhinayagarwal · 2023-01-04T05:29:42Z

A very happy new year to you too!

Hopefully, I can get back to this PR some time this week.

abhinayagarwal · 2023-03-27T13:54:48Z

Can you please update the branch with latest changes?

…er.git into issue-582

Oliver-Loeffler · 2023-03-27T20:17:03Z

I've now merged the latest changes into this one. Also applied reformatting according what checkstyle finds for the change files in main.

abhinayagarwal · 2023-03-30T03:42:34Z

Testing the changes, it looks good on Mac (including the positioning). However, I find the text on the buttons to be too descriptive for a dialog.

Here is a screenshot from IntelliJ IDEA of a dialog when project is not found:

Oliver-Loeffler · 2023-03-30T05:16:22Z

Thanks, very good example. Well I will rework it accordingly tonight.

Oliver-Loeffler · 2024-03-19T18:22:32Z

With the reworked ErrorDialog it is also now possible to have a useful title for the error detail. Also in SceneBuilderApp the dialog is now called in such way, so we always have a correct modality and one cannot loose a window.

As mentioned before, the error detail is a detail, the dialog requires user action to open.

Actually, it would be quite useful to add some proper log messages here.

…th WelcomeDialogWindow as owner as a new method.

…r used.

…ions.

…n year.

Oliver-Loeffler · 2024-03-27T17:19:26Z

If this PR gets approved and merged, I'd like to continue with #576 which then would fix #120.

abhinayagarwal

LGTM!

Oliver-Loeffler · 2024-03-28T06:29:34Z

It took a while but actually I am also now happy with the outcome. Thanks for your feedback.

Oliver-Loeffler

Thanks for the feedback @abhinayagarwal and @AlmasB. That seems to be okay now. The issues with the error dialog are valid but should be resolved in a separate PR.

Oliver-Loeffler · 2024-04-05T05:07:44Z

This one fixed also #600.

Oliver-Loeffler mentioned this pull request Nov 7, 2022

feat: Enabled loading of FXML files via drag&drop to WelcomeScreen. #591

Closed

4 tasks

abhinayagarwal self-requested a review November 8, 2022 03:49

Oliver-Loeffler and others added 7 commits November 8, 2022 17:19

fix: Scene Builder will ask to remove missing files from list of rece…

1641ee4

…nt projects. gluonhq#582

fix: incremented version to 20.0.0-SNAPSHOT. (gluonhq#598)

b303f9d

Co-authored-by: Oliver-Loeffler <Oliver-Loeffler@users.noreply.github.com>

build: Moved maven surefire plugin from kit-pom to parent-pom so that…

484c4dd

… eventually tests are also picked up for app module.

build: Add Maven Wrapper to the project (gluonhq#588)

4cd7775

Co-authored-by: Oliver-Loeffler <Oliver-Loeffler@users.noreply.github.com>

fix: Removed FX8 qualifier in BuiltInLibrary (gluonhq#592)

484a1fe

Co-authored-by: Oliver-Loeffler <Oliver-Loeffler@users.noreply.github.com>

fix: Disabled mnemonic parsing on RecentDocumentsButton instances on …

437dadc

…welcome page in oder to have correct file name rendering for filenames with underscores. (gluonhq#578) Co-authored-by: Oliver-Loeffler <Oliver-Loeffler@users.noreply.github.com>

Modified error handling so that WelcomePage is no longer closed after…

e676e1a

… confirming the error dialog.

Oliver-Loeffler force-pushed the issue-582 branch from 143f925 to e676e1a Compare November 8, 2022 16:21

Merge branch 'gluonhq:master' into issue-582

8d14862

Oliver-Loeffler force-pushed the issue-582 branch from 7e27963 to f360fe2 Compare December 11, 2022 18:28

Added warning and informative logging for cases of removing files fro…

f11a8a1

…m recent items and for cases where errors occured during FXML loading.

Oliver-Loeffler force-pushed the issue-582 branch from fb9ad13 to f11a8a1 Compare January 3, 2023 20:55

Oliver-Loeffler and others added 3 commits March 27, 2023 22:06

Merge branch 'gluonhq:master' into issue-582

8ef7724

Formatted according to checkstyle rules.

9a1a7ce

Merge branch 'issue-582' of git@github.com:Oliver-Loeffler/scenebuild…

3e4ed5e

…er.git into issue-582

Merge branch 'gluonhq:master' into issue-582

8d9a36f

Oliver-Loeffler added 2 commits March 19, 2024 19:12

Reworked ErrorDialog to have proper modality and icon.

0089e1f

Again reworked how ownership is detected to preserve modality.

d14bceb

abhinayagarwal reviewed Mar 21, 2024

View reviewed changes

Comment thread app/src/main/java/com/oracle/javafx/scenebuilder/app/SceneBuilderApp.java Outdated

Comment thread app/src/main/java/com/oracle/javafx/scenebuilder/app/SceneBuilderApp.java

Comment thread app/src/main/java/com/oracle/javafx/scenebuilder/app/SceneBuilderApp.java Outdated

Oliver-Loeffler added 2 commits March 21, 2024 22:49

Consolidated calls of performOpenFiles() and handleFileOpenResul() wi…

c2f76a2

…th WelcomeDialogWindow as owner as a new method.

Licens header updated.

19cabeb

abhinayagarwal reviewed Mar 22, 2024

View reviewed changes

Comment thread app/src/main/java/com/oracle/javafx/scenebuilder/app/SceneBuilderApp.java Outdated

Oliver-Loeffler and others added 8 commits March 25, 2024 22:19

Reworked consolidation so, that the FileOpenResult record is no longe…

45f2ce8

…r used.

Removed FileOpenRecord.

eed0bf9

Merge branch 'gluonhq:master' into issue-582

ccff81c

Reorganized imports.

4bb357a

Removed conditional for logging.

a3e68ec

Removed the supplier.

3f4cdff

Formatting.

bc791e2

Added an override for performOpenFiles and applied formatting correct…

38f3729

…ions.

abhinayagarwal reviewed Mar 27, 2024

View reviewed changes

Oliver-Loeffler and others added 5 commits March 27, 2024 18:00

Replaced wildcards with fully qualified names.

323e494

Merge branch 'gluonhq:master' into issue-582

1aea4be

Removed unused keys from Chinese translation.

1c945e4

Corrected license header for this file to state only 2024 as inceptio…

0df317d

…n year.

Removed english text from zh_CN translation.

ff9f3ca

abhinayagarwal approved these changes Mar 28, 2024

View reviewed changes

AlmasB approved these changes Mar 28, 2024

View reviewed changes

Comment thread kit/src/main/java/com/oracle/javafx/scenebuilder/kit/editor/panel/util/dialog/ErrorDialog.java

Comment thread app/src/main/java/com/oracle/javafx/scenebuilder/app/SceneBuilderApp.java

Oliver-Loeffler commented Mar 28, 2024

View reviewed changes

abhinayagarwal merged commit 976c754 into gluonhq:master Mar 29, 2024

Oliver-Loeffler deleted the issue-582 branch April 2, 2024 07:42

Oliver-Loeffler mentioned this pull request Apr 5, 2024

SceneBuilder closes unexpectedly when an error occurs during FXML file loading #600

Closed

Uh oh!

Conversation

Oliver-Loeffler commented Oct 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue

Progress

Uh oh!

Oliver-Loeffler commented Oct 10, 2022

Uh oh!

abhinayagarwal commented Nov 8, 2022

Uh oh!

Oliver-Loeffler commented Nov 8, 2022

Uh oh!

Oliver-Loeffler commented Nov 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Oliver-Loeffler commented Dec 11, 2022

Uh oh!

Oliver-Loeffler commented Dec 11, 2022

Uh oh!

Oliver-Loeffler commented Jan 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abhinayagarwal commented Jan 4, 2023

Uh oh!

abhinayagarwal commented Mar 27, 2023

Uh oh!

Oliver-Loeffler commented Mar 27, 2023

Uh oh!

abhinayagarwal commented Mar 30, 2023

Uh oh!

Oliver-Loeffler commented Mar 30, 2023 via email

Uh oh!

Oliver-Loeffler commented Mar 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Oliver-Loeffler commented Mar 27, 2024

Uh oh!

abhinayagarwal left a comment

Choose a reason for hiding this comment

Uh oh!

Oliver-Loeffler commented Mar 28, 2024

Uh oh!

Uh oh!

Uh oh!

Oliver-Loeffler left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Oliver-Loeffler commented Apr 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Oliver-Loeffler commented Oct 10, 2022 •

edited

Loading

Oliver-Loeffler commented Nov 8, 2022 •

edited

Loading

Oliver-Loeffler commented Jan 3, 2023 •

edited

Loading

Oliver-Loeffler commented Mar 19, 2024 •

edited

Loading