Skip to content

ci: bump golangci lint (cherry-pick #25513 to version-2026.8) #25522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
authentik-cherry-pick wants to merge 3 commits into
base: version-2026.8
Choose a base branch
from
+8 −9
Open

ci: bump golangci lint (cherry-pick #25513 to version-2026.8) #25522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0400c03
ci: bump golangci lint (#25513)
BeryJu Aug 26, 2026
7f42970
fix complaints
BeryJu Aug 26, 2026
516c318
add spell
BeryJu Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .github/workflows/ci-outpost.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,6 @@ jobs:
- name: golangci-lint
uses: golangci/golangci-lint-action@ba0d7d2ec06a0ea1cb5fa41b2e4a3ab91d21278a # v8
with:
# latest (v2.13.0) bundles honnef.co/go/tools v0.8.0-rc.1, whose nilness
# analyzer panics on getsentry/sentry-go ("unhandled builtin recover",
# https://github.com/dominikh/go-tools/issues/1725). Unpin once a
# release with the fix ships.
version: v2.12.2
args: --timeout 5000s --verbose
skip-cache: true
test-unittest:
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module goauthentik.io

go 1.26.0
go 1.27.0

require (
beryju.io/ldap v0.2.1
Expand Down
2 changes: 2 additions & 0 deletions internal/outpost/proxyv2/application/mode_proxy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ func (a *Application) configureProxy() error {
}
rsp := sentry.StartSpan(context.TODO(), "authentik.outposts.proxy.application_transport")
rp := &httputil.ReverseProxy{
// This code is deprecated/replaced on main anyways, so this is fine
//nolint:staticcheck
Director: a.proxyModifyRequest(u),
Transport: web.NewTracingTransport(rsp.Context(), a.getUpstreamTransport()),
ErrorHandler: a.newProxyErrorHandler(),
Expand Down
5 changes: 2 additions & 3 deletions internal/utils/tls.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,15 @@ import (

func GetTLSConfig() *tls.Config {
// Based on
// https://ssl-config.mozilla.org/#server=go&version=1.25&config=intermediate&guideline=5.7
// https://configurator.tlsref.org/#server=go&version=1.27&config=intermediate&hsts&guideline=6.0
tlsConfig := &tls.Config{
MinVersion: tls.VersionTLS12,
CurvePreferences: []tls.CurveID{
tls.X25519,
tls.CurveP256,
tls.CurveP384,
},
PreferServerCipherSuites: true,
CipherSuites: []uint16{},
CipherSuites: []uint16{},
}

excludedCiphers := []uint16{
Expand Down
2 changes: 2 additions & 0 deletions internal/web/proxy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,8 @@ func (ws *WebServer) configureProxy() {
ws.log.WithField("url", req.URL.String()).WithField("headers", req.Header).Trace("tracing request to backend")
}
rp := &httputil.ReverseProxy{
// This code is deprecated/replaced on main anyways, so this is fine
//nolint:staticcheck
Director: director,
Transport: ws.upstreamHttpClient().Transport,
}
Expand Down
1 change: 1 addition & 0 deletions locale/en/dictionaries/golang.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,4 @@ gorm
gorm
gorm*
logger
nolint
Loading