Delay Spec lifter argument conversions until exception handlers inside lift_fun - #2108
Draft
sim642 wants to merge 1 commit into
Draft
Delay Spec lifter argument conversions until exception handlers inside lift_fun#2108sim642 wants to merge 1 commit into
Spec lifter argument conversions until exception handlers inside lift_fun#2108sim642 wants to merge 1 commit into
Conversation
…e lift_fun In particular, this should fix an issue encountered by Kalmer's QSolvers where the Deadcode exception escaped to the top level due to conv on bottom happening outside the exception handler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In particular, this should fix an issue encountered by Kalmer's QSolvers where the
Deadcodeexception escaped to the top level due toconvon bottom happening outside the exception handler.TODO