FwdChecker: Avoid re-checking locals because of global dependencies - #2117
Open
michael-schwarz wants to merge 3 commits into
Open
FwdChecker: Avoid re-checking locals because of global dependencies#2117michael-schwarz wants to merge 3 commits into
michael-schwarz wants to merge 3 commits into
Conversation
Member
Author
|
After discussion with Helmut, it seems that perhaps checking for a global should not enqueue any locals at all? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid evaluating the same local RHS multiple times during post-solution checking.
The worklist set previously tracked only queued locals. Once processed, a local was removed and could later be scheduled again through a global's influence set, causing redundant transfer-function evaluations.
Neither output map prevents this:
tau_outdeduplicates globals, but a global's first encounter can still schedule already-processed locals.sigma_outonly deduplicates locals discovered through local side effects. Start unknowns and global influences calladd_workdirectly, while checking it insideadd_workwould suppress first-time evaluations becausecheck_localupdatessigma_outbefore scheduling.This change keeps scheduled locals in the worklist set after dequeuing, making it a record of all locals seen during the current checker run. The set is reset between checker invocations.
On an example originating from our witness-validation work, this reduced postsolver runtime from several minutes to about 45 seconds.