Improve readability of Spec lifted domains - #2118
Open
sim642 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did something like this in #1294 but various
Speclifters have been added since and they should also be adapted.There are examples of the improvements in cram tests.
As an another example, consider
./regtest.sh 04 01 --trace sol --trace sol2.From local states, this removes the following unwieldy prefix:
From global states, this removes prefixes like:
This makes tracing a lot more readable by removing redundant information and some massive indentations.
Additionally it adds names to some domains, so they're more descriptive than
maporchain.