Repository navigation
Resolve issue related to wrong specs and non counting extra_working_days - #34
Merged
Merged
Conversation
anatoliliotych
force-pushed
the
master
branch
from
January 10, 2022 11:13
671f340 to
bdf3aae
Compare
anatoliliotych
force-pushed
the
master
branch
from
October 26, 2023 18:20
0131413 to
2054218
Compare
Author
|
@JoeSouthan could you please review? |
anatoliliotych
force-pushed
the
master
branch
from
October 26, 2023 18:40
2054218 to
5929a62
Compare
# Conflicts: # lib/business/calendar.rb
Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
JoeSouthan
approved these changes
Sep 28, 2026
Contributor
|
Thanks for the contribution @anatoliliotych, sorry it took so long to get around to (we don't use the |
Author
No worries :) Thanks for merging! We use it a lot and this is why I found it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code changes in this PR resolve the problem by accurately counting business days, including those instances where an
extra_workingday occurs on a weekend.