Guard nil pointers in MarshalIndent / MarshalText sibling paths - #588
Open
mahirhir wants to merge 1 commit into
Open
Guard nil pointers in MarshalIndent / MarshalText sibling paths#588mahirhir wants to merge 1 commit into
mahirhir wants to merge 1 commit into
Conversation
…ode paths The nil-pointer guard added in goccy#524 (for []*time.Time via AppendMarshalJSON) was missing from the three sibling encode helpers: AppendMarshalJSONIndent, AppendMarshalText and AppendMarshalTextIndent. Encoding a nil pointer whose Marshaler/TextMarshaler method has a value/deref receiver (e.g. json.MarshalIndent([]*time.Time{nil}), or a slice of nil *T implementing TextMarshaler) panicked instead of emitting null, diverging from encoding/json. Apply the same `rv.Kind() == reflect.Ptr && rv.IsNil()` guard to all three siblings and add slice tests covering the JSON-indent and text/text-indent paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merged PR #524 added a nil-pointer guard to
AppendMarshalJSON, but the same indirection-without-nil-check exists in three sibling helpers ininternal/encoder/encoder.go:AppendMarshalJSONIndent,AppendMarshalText,AppendMarshalTextIndent. Sojson.MarshalIndent([]*time.Time{nil})and slices of nil*TimplementingTextMarshalerwith a value receiver panic instead of emittingnull, diverging from stdlibencoding/json.The fix ports the same guard #524 added into the three sibling paths. Verified both ways with
go test: old panics on all three, fixed emitsnull/indented; the existingTestNilMarshal(nil-safe-receiver) still passes, full suite green, 0 regression.