generator: emit standard generated-code markers - #593
Open
zbarsky-openai wants to merge 1 commit into
Open
Conversation
Use the standard Go generated-file marker in the encoder generator and VM template, then regenerate the checked-in encoder outputs. Go tooling recognizes generated files only when their marker ends in "DO NOT EDIT.". The exclamation point made Staticcheck analyze the generated encoder state machines as handwritten source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The encoder generator currently emits
DO NOT EDIT!, but Go recognizes generated files only when the marker ends inDO NOT EDIT.. Consequently,go/ast.IsGeneratedand Staticcheck treat the large generated encoder state machines as handwritten source.Update the encoder generator and VM template to emit Go's standard marker and regenerate all five checked-in encoder outputs. The generated code is otherwise unchanged.
Validation:
go generate ./internal/...(repeated; output is idempotent)go test -p 4 ./...