Fix CI failures on master caused by outdated Go versions - #594
Open
goccy wants to merge 1 commit into
Open
Conversation
Two failures after #567 landed: - "Build on limited environment" uses the golang:1.18 image, which cannot compile atomic.Pointer (added in Go 1.19, the minimum version declared in go.mod). Bump the image to golang:1.19 and drop the obsolete 'version' attribute from docker-compose.yml. - "Test (macos-latest, *)" aborts with 'dyld: missing LC_UUID load command'. Binaries built by Go < 1.22 lack the LC_UUID load command and are rejected by dyld on current macos-latest runners. Run only the latest stable Go on macOS and keep 1.19-1.21 coverage on Linux and Windows. Also add 'stable' to the matrix and disable fail-fast so one broken combination no longer cancels the rest. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #594 +/- ##
=======================================
Coverage 78.52% 78.52%
=======================================
Files 53 53
Lines 16717 16717
=======================================
Hits 13127 13127
Misses 2958 2958
Partials 632 632 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the two CI failures on master that surfaced after #567 landed:
Build on limited environment
docker-compose.ymlpinnedgolang:1.18, which cannot compileatomic.Pointer(added in Go 1.19, the minimum version declared ingo.mod):Bumped the image to
golang:1.19(verified locally thatgo test -c .builds with go1.19.13) and removed the obsoleteversionattribute.Test (macos-latest, 1.19 / 1.20 / 1.21)
Binaries built by Go < 1.22 lack the
LC_UUIDload command and are killed by dyld on currentmacos-latestrunners, so none of the matrix versions can run there anymore. This is an environment issue unrelated to #567 (it also failed on the previouspull_requestrun in 2025-11). macOS now runs only the lateststableGo via matrixexclude, while 1.19–1.21 coverage is kept on Linux and Windows.Also added
stableto the matrix (previously nothing newer than 1.21 was tested) and setfail-fast: falseso one broken combination no longer cancels the rest of the matrix.🤖 Generated with Claude Code