Add Decoder.DisallowDuplicateFields to reject duplicate object keys - #606
Open
ChrisJr404 wants to merge 1 commit into
Open
Add Decoder.DisallowDuplicateFields to reject duplicate object keys#606ChrisJr404 wants to merge 1 commit into
ChrisJr404 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #385.
This adds a
DisallowDuplicateFieldsoption onDecoder, matching the existingDisallowUnknownFields. When it is set, decoding into a struct returns an error if an object contains more than one key that maps to the same field, instead of silently letting the last value win. That is useful when you want stricter parsing for compatibility with other JSON implementations (the issue links dsnet's writeup on why duplicate keys are a footgun).It reuses the
seenFieldsbookkeeping that was already there forDecodeFieldPriorityFirstWin, so the default decode path is unchanged and the map is only allocated when the option is turned on.