bump CMake requirement to 3.25

[van800]

Using [SYSTEM] keyword added in CMake 3.25
https://cmake.org/cmake/help/v3.25/command/add_subdirectory.html?highlight=add_subdirectory

Aslo find_program(... REQUIRED) — added in 3.18
https://cmake.org/cmake/help/latest/command/find_program.html

[dsnopek]

@enetheru What do you think?

I don't know how important it is to support older versions of CMake. If it is important, then the other option is trying to not use these two features. Given my limited experience with CMake, I don't personally have an opinion either way

[van800]

Version 3.25 is also very old - year 2022.
https://github.com/Kitware/CMake/releases?page=14

[enetheru]

haha, awesome, @van800 I wonder how this came up, was it some tooling? or a person who noticed?
@dsnopek I have no information about how its used in the wild, but since those features were being used and nobody mentioned it before now i think its reasonable to bump the version to match the features. It also opens the door for anything included in newer version, I believe I have something in there waiting for a version bump.
here is a good resource for cmake versions across platforms: https://cliutils.gitlab.io/modern-cmake/chapters/intro/installing.html

but if we don't want to bump the versions, I don't think either of those features are necessary.

• REQUIRED can be worked around with a check after the fact. pretty sure its looking for python.
• I don't even think SYSTEM should be used, it was carried over from prior setup before I touched it. I can't imagine a scenario to need it, but that's probably because I've never needed it.

[enetheru]

Oh man i didn't notice which repo we were in.
I wonder why I put the SYSTEM keyword in there. going to have to check that one. brb

[enetheru]

I think remember now?, marking the inclusion of godot-cpp directory as SYSTEM prevents the godot-cpp files from being added to the install targets. but thats not relevant here, and is a pretty hacky solution for that. I think it can just be removed.

[van800]

I bumped into it while testing myself on an older Ubuntu while testing a fix.

BTW, I managed to verify that my CI fails, when I set minimum required to 3.25 and install cmake 3.24 van800/godot-support#5

CMake 3.25 or higher is required. You are running version 3.24.0

Version 3.17 was so poor, that it wasn't even able to communicate this error clearly, so I had to bump at least to 3.24 to see the error.