Draft
feat: add configurable bit-length, sequence number parameters, and ID generation method#87
Conversation
Open
- Add workerIdBitLength, datacenterBitLength, sequenceBitLength properties to Snowflake with setters/getters (defaults maintain backward compat) - Add maxSequenceNumber and minSequenceNumber configuration - Update buildId(), parseId(), id(), idForTimestamp() to use instance bit lengths instead of hardcoded constants - Update getDefaultSequenceResolver() to pass max/min to RandomSequenceResolver - Add minSequence support to RandomSequenceResolver with abs() fix for correct non-negative sequence generation - Add comprehensive tests for all new parameters - Document new configuration options in README Agent-Logs-Url: https://github.com/godruoyi/php-snowflake/sessions/035a009f-7538-4a22-870d-7f2b82a24220 Co-authored-by: godruoyi <16079222+godruoyi@users.noreply.github.com>
…omment Agent-Logs-Url: https://github.com/godruoyi/php-snowflake/sessions/035a009f-7538-4a22-870d-7f2b82a24220 Co-authored-by: godruoyi <16079222+godruoyi@users.noreply.github.com>
Agent-Logs-Url: https://github.com/godruoyi/php-snowflake/sessions/035a009f-7538-4a22-870d-7f2b82a24220 Co-authored-by: godruoyi <16079222+godruoyi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix IdGeneratorOptions parameters for consistency
feat: add configurable bit-length and sequence number parameters
Apr 23, 2026
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #87 +/- ##
============================================
- Coverage 98.71% 98.18% -0.54%
- Complexity 91 128 +37
============================================
Files 7 8 +1
Lines 234 330 +96
============================================
+ Hits 231 324 +93
- Misses 3 6 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
@copilot Does this support custom WorkerIdBitLength, SeqBitLength, MaxSeqNumber, and MinSeqNumber parameters ? like i set WorkerIdBitLength = 0 datacenterBitLength = 0 and set setSequenceBitLength = 20 and set timestampbitlength = 20 what ever i want? |
The minimum for setWorkerIdBitLength() is lowered from 1 to 0, enabling fully single-node setups where all non-timestamp bits go to the sequence (e.g. dc=0, worker=0, seq=20 gives up to 2^20-1 sequences per ms). Adds a dedicated test and updates the README with a single-node example. Agent-Logs-Url: https://github.com/godruoyi/php-snowflake/sessions/8e497dfa-9e5b-4cdb-8f99-e6d71711b140 Co-authored-by: godruoyi <16079222+godruoyi@users.noreply.github.com>
Author
Yes — all four parameters are supported. Here's a quick map:
Constraint: Your exact scenario ( $snowflake = new Snowflake(0, 0);
$snowflake
->setDatacenterBitLength(0)
->setWorkerIdBitLength(0)
->setSequenceBitLength(20); // up to 2^20−1 = 1 048 575 sequences/ms
$snowflake->id();There is no explicit Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Owner
|
@copilot This looks like a more advanced use case. The idea is that we allow callers to For example, a caller could allocate more bits to the datacenter and machine ID fields, In this model, the Snowflake implementation itself doesn't need to care about the |
Author
That's exactly right. The implementation is intentionally semantic-free — it just shifts bits according to whatever lengths the caller configured. The caller owns the meaning of each field. The IP-to-node-ID pattern works well with this. For example, using the last two octets of the host IP: $ip = explode('.', gethostbyname(gethostname()));
$datacenter = (int) $ip[2] & 0x1F; // octet 3, low 5 bits
$worker = (int) $ip[3] & 0x1F; // octet 4, low 5 bits
$snowflake = new Snowflake($worker, $datacenter);
$snowflake->id();Or with a larger bit allocation to cover a wider IP range: $lastOctet = (int) $ip[3]; // 0–255 needs 8 bits
$snowflake = new Snowflake($lastOctet, 0);
$snowflake
->setDatacenterBitLength(0)
->setWorkerIdBitLength(8) // fits 0–255
->setSequenceBitLength(14); // 8+14=22, still within the budget
$snowflake->id();The library doesn't validate or care what those numbers mean — it just packs them into the right bit positions. |
Owner
|
@copilot Is it possible to have our Snowflake implementation impose no restrictions on the bit For example:
We don't enforce any constraints — we just generate based on what the caller gives us. |
Agent-Logs-Url: https://github.com/godruoyi/php-snowflake/sessions/84a5f6d9-cbaf-4b0a-b841-764f3e45eefd Co-authored-by: godruoyi <16079222+godruoyi@users.noreply.github.com>
Agent-Logs-Url: https://github.com/godruoyi/php-snowflake/sessions/84a5f6d9-cbaf-4b0a-b841-764f3e45eefd Co-authored-by: godruoyi <16079222+godruoyi@users.noreply.github.com>
Author
Yes, that's feasible and now implemented in commit The per-field upper limits (0–15 for worker/datacenter, 3–21 for sequence) and the old sum ≤ 22 cap are gone. The only remaining constraint is the hard technical one: Examples that now work: // 1-bit sequence (2 values: 0 and 1)
(new Snowflake())->setSequenceBitLength(1);
// Very large timestamp range — give 55 bits to timestamp
(new Snowflake(0, 0))->setDatacenterBitLength(0)->setWorkerIdBitLength(0)->setSequenceBitLength(7); // 63−7=56 bits for ts
// Huge datacenter space
(new Snowflake(0, 0))->setWorkerIdBitLength(0)->setSequenceBitLength(6)->setDatacenterBitLength(30); // 30+0+6=36≤62A note is added to Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Owner
|
@copilot what is this mean ? |
Agent-Logs-Url: https://github.com/godruoyi/php-snowflake/sessions/e951592f-f68f-4196-a5ab-4fd16165c990 Co-authored-by: godruoyi <16079222+godruoyi@users.noreply.github.com>
Agent-Logs-Url: https://github.com/godruoyi/php-snowflake/sessions/e951592f-f68f-4196-a5ab-4fd16165c990 Co-authored-by: godruoyi <16079222+godruoyi@users.noreply.github.com>
Author
That field specifies the ID generation method for handling sequence overflow:
Both are now implemented in commit use Godruoyi\Snowflake\Snowflake;
// Drift (default — no call needed)
$snowflake = new Snowflake;
$snowflake->setMethod(Snowflake::DRIFT_METHOD); // 1
$snowflake->id();
// Traditional
$snowflake->setMethod(Snowflake::TRADITIONAL_METHOD); // 2
$snowflake->id(); |
Copilot
AI
changed the title
feat: add configurable bit-length and sequence number parameters
feat: add configurable bit-length, sequence number parameters, and ID generation method
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PHP library had no equivalent for the Go version's
WorkerIdBitLength,SeqBitLength,MaxSeqNumber,MinSeqNumber, andMethodparameters — all bit allocations were hardcoded constants with no way to adjust them, and only one ID generation strategy was available.Changes
src/Snowflake.phpworkerIdBitLength(≥ 0),datacenterBitLength(≥ 0),sequenceBitLength(≥ 1) with setters/getters; the only hard constraint is that their sum must not exceed 62 (the remaining bits are used for the timestamp). No per-field upper bounds are enforced — the caller is free to allocate bits however they see fit.workerIdBitLengthanddatacenterBitLengthmay be set to0for single-node deploymentsmaxSequenceNumber(0 = auto-derive fromsequenceBitLength) andminSequenceNumber(default 0; reserving low sequence numbers for clock-rollback slots, etc.)maxSequenceNumber > minSequenceNumberwhen both non-zeromethodproperty with two constants mirroring the GoMethodfield:DRIFT_METHOD(1, default): on sequence overflow the timestamp is incremented by 1 (borrowing a future millisecond) — no blocking, maximum throughput. A$lastTimestampproperty ensures IDs remain strictly monotonic across calls.TRADITIONAL_METHOD(2): on sequence overflow the generator spin-waits until the real clock advances to the next millisecond.buildId(),parseId(),id(),idForTimestamp()now use instance bit lengths instead of hardcoded constants; defaults are identical to prior behavior — fully backward compatiblesrc/RandomSequenceResolver.phpminSequencesupport; initial per-ms sequence now drawn from[minSequence, maxSequence]inclusivecrc32(…) % maxtoabs(crc32(…)) % range— eliminates the pre-existing negative sequence bugREADME.md— documented all new options with examples, including single-node, IP-derived node ID, and method selection examplesUsage
Single-node example (no worker/datacenter fields, all bits for sequence):
Choosing the ID generation method: