Skip to content

fix(config): default GoBinaryEnvVars to proxy.golang.org, not direct-only #2143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
karlkfi wants to merge 1 commit into from
+4 −4
Closed

fix(config): default GoBinaryEnvVars to proxy.golang.org, not direct-only #2143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config.dev.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ GoEnv = "development"
# ATHENS_GO_BINARY_ENV_VARS='GODEBUG=true'
# Then the final value that the Go binary will receive is ["GODEBUG=true"] and NOT ["GOPROXY=direct", "GODEBUG=true"]
# Therefore, whether you use the config file or the env var, make sure you have all the values you need there.
GoBinaryEnvVars = ["GOPROXY=direct"]
GoBinaryEnvVars = ["GOPROXY=https://proxy.golang.org,direct"]

# GoGetWorkers specifies how many times you can concurrently
# go mod download, this is so that low performance instances
Expand Down
2 changes: 1 addition & 1 deletion pkg/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ func Load(configFile string) (*Config, error) {
func defaultConfig() *Config {
return &Config{
GoBinary: "go",
GoBinaryEnvVars: EnvList{"GOPROXY=direct"},
GoBinaryEnvVars: EnvList{"GOPROXY=https://proxy.golang.org,direct"},
GoEnv: "development",
GoGetWorkers: 10,
ProtocolWorkers: 30,
Expand Down
2 changes: 1 addition & 1 deletion pkg/config/config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ func TestParseExampleConfig(t *testing.T) {
TraceSamplingFraction: 1.0,
StatsExporter: "prometheus",
SingleFlightType: "memory",
GoBinaryEnvVars: []string{"GOPROXY=direct"},
GoBinaryEnvVars: []string{"GOPROXY=https://proxy.golang.org,direct"},
SingleFlight: expSingleFlight,
SumDBs: []string{"https://sum.golang.org"},
NoSumPatterns: []string{},
Expand Down
2 changes: 1 addition & 1 deletion pkg/config/testdata/config.dev.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ GoEnv = "development"
# ATHENS_GO_BINARY_ENV_VARS='GODEBUG=true'
# Then the final value that the Go binary will receive is ["GODEBUG=true"] and NOT ["GOPROXY=direct", "GODEBUG=true"]
# Therefore, whether you use the config file or the env var, make sure you have all the values you need there.
GoBinaryEnvVars = ["GOPROXY=direct"]
GoBinaryEnvVars = ["GOPROXY=https://proxy.golang.org,direct"]

# GoGetWorkers specifies how many times you can concurrently
# go mod download, this is so that low performance instances
Expand Down
Loading