Skip to content

gnoi/os: limit OS image size in ReceiveOS to prevent unbounded memory allocation #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kazisabu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

gnoi/os: limit OS image size in ReceiveOS to prevent unbounded memory allocation #404

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions gnoi/os/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ import (
)

var receiveChunkSizeAck uint64 = 12000000
// maxOSImageSize limits the maximum size of an OS image accepted by ReceiveOS
// to prevent unbounded memory allocation (DoS).
const maxOSImageSize = 1 << 30 // 1GB

// Server is an OS Management service.
type Server struct {
Expand Down Expand Up @@ -179,6 +182,9 @@ func ReceiveOS(stream pb.OS_InstallServer) (*bytes.Buffer, error) {
switch in.Request.(type) {
case *pb.InstallRequest_TransferContent:
bb.Write(in.GetTransferContent())
if bb.Len() > maxOSImageSize {
return nil, errors.New("OS image exceeds maximum size")
}
case *pb.InstallRequest_TransferEnd:
log.V(1).Info("InstallRequest:\n", proto.MarshalTextString(in))
return bb, nil
Expand Down