Skip to content

chore: remove Python API code - #5869

Merged
michaelkedar merged 3 commits into
google:masterfrom
michaelkedar:🐍🚮
Aug 19, 2026

Hidden character warning

The head ref may contain hidden characters: "\ud83d\udc0d\ud83d\udeae"
Merged

michaelkedar merged 3 commits into
google:masterfrom
michaelkedar:🐍🚮

Conversation

@michaelkedar

Copy link
Copy Markdown
Member

Getting rid of all the Python API implementation, since our shiny new Go implementation works.

  • Removed the gcp/api/ directory
    • Moved related Protos into proto/ directory
      • Removed the googleapis submodule and vendored the two required protos directly
    • Moved ESPv2 Dockerfile to docker directory
    • Re-linked terraform symlinks to point to new locations of files
  • Replaced API tester python script with bash script
  • Replaced build_swagger.py script with bash script

@michaelkedar
michaelkedar requested review from a team and jess-lowe August 19, 2026 00:59
"CVSS_V3",
"CVSS_V2"
"CVSS_V2",
"CVSS_V4",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this ordering annoys me but I'm assuming this is generated?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this file is generated.
This is the order of the enum in the osv-schema proto 🙃

string delete = 5;

// Maps to HTTP PATCH. Used for updating a resource.
string patch = 6;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at what point would we need to support the QUERY method too?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if ESPv2 decides to support it

"DISCUSSION",
"EVIDENCE",
"FIX",
"GIT",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we keeping 'git' around even though it was a mistake from like 5 years ago?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's technically in the schema (and hypothetically can be returned by a record), so I guess it stays 🤷

jess-lowe
jess-lowe previously approved these changes Aug 19, 2026

@jess-lowe jess-lowe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bye bye python

@michaelkedar
michaelkedar merged commit c6d79f0 into google:master Aug 19, 2026
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants