-
Notifications
You must be signed in to change notification settings - Fork 221
Feature/image in alerts #283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
24fb00d
Add image_url to alert
gcamp b3cb3e5
Add details about essential information in the image
gcamp f183864
Add notice about mainly text
gcamp 3033eaa
Update discouraged image list
gcamp e2b9e80
Support list of images
gcamp 36ecabe
Fix typo
gcamp a4162ec
Fix typo
gcamp bee0b8d
Revert table of content
gcamp 9a5dfd6
Merge branch 'feature/image_in_alerts' of github.com:TransitApp/trans…
gcamp d9902eb
Add media type, alt text
gcamp 172c85d
Merge and fix conflicts
gcamp 401aede
Fix URL writing
gcamp 3d711b2
Fix text reference in TranlatedImage
gcamp 06b17e8
Fix copy/paste error
gcamp 6dffdcb
Clarify langage about image selection
gcamp 6c518e1
Clarify alt text description
gcamp 3fbbbec
Update gtfs-realtime/proto/gtfs-realtime.proto
gcamp 49518bc
Use RFC 2119 definition for requirement description
gcamp 124614a
Add missing extension attribute in TranslatedImage
gcamp b76a38b
Revert editorial changes
gcamp 506b365
Revert editorial changes
gcamp 0de4cbc
Max size to 2MB
gcamp 1f4fa39
Add note about URL needing changing if the image changes
gcamp 1b0d6a0
Use MUST for the size limit
gcamp ec2d42a
Move alternative_text into the parent alert
gcamp 0899f9f
Add missing experimenal note for image_alternative_text
gcamp e143763
Add note about image orderign
gcamp 56fa28d
Only allow one image
gcamp 1274fad
Fix image text
gcamp df127da
Add mention of URL escaping, mirroring the one in GTFS static
gcamp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.