Changes needed for MPA support#555
Open
dorasun wants to merge 2 commits into
Open
Conversation
Change-Id: Iaefffce0a2955c3df4369affc6335fb9313151df
bobhancockg
requested changes
Jul 16, 2026
| # code. | ||
| # | ||
| # Running the example with -h will print the command line usage. | ||
| options[:customer_id] = 'INSERT_CUSTOMER_ID_HERE' |
Contributor
There was a problem hiding this comment.
Where do you check whether the user has replaced this placeholder before invoking the main method?
|
|
||
| # Create a query that will retrieve all the pending MPA reviews. | ||
| query = <<~QUERY | ||
| SELECT |
Contributor
There was a problem hiding this comment.
WHERE clause fields must be present in the SELECT clause. Added multi_party_auth_review.review_status to the SELECT clause.
| client = Google::Ads::GoogleAds::GoogleAdsClient.new | ||
|
|
||
| # Retrieve the list of pending MPA reviews. | ||
| pending_reviews = fetch_pending_mpa_reviews(client, customer_id) |
Contributor
There was a problem hiding this comment.
Consider adding a helpful message if pending_reviews is empty to alert the user.
| ], | ||
| ) | ||
|
|
||
| result_or_error = response.result_or_error.first |
Contributor
There was a problem hiding this comment.
Is it possible for result_or_error to be empty? If so, first will return nil , and result_or_error.result will raise a NoMethodError on NilClass .
Change-Id: Ie7f15d5ef3968dd177b8eddfbf43b566f72fca3c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: Iaefffce0a2955c3df4369affc6335fb9313151df