Skip to content

fix: correct exponential backoff by replacing XOR with bit shift #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
m-iskw335 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: correct exponential backoff by replacing XOR with bit shift #723

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions api_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ import (
const maxChunkSize = 8 * 1024 * 1024 // 8 MB chunk size
const maxRetryCount = 3
const initialRetryDelay = time.Second
const delayMultiplier = 2

type apiClient struct {
clientConfig *ClientConfig
Expand Down Expand Up @@ -650,7 +649,7 @@ func (ac *apiClient) upload(ctx context.Context, r io.Reader, uploadURL string,
select {
case <-ctx.Done():
return nil, fmt.Errorf("upload aborted while waiting to retry (attempt %d, offset %d): %w", attempt+1, offset, ctx.Err())
case <-time.After(initialRetryDelay * time.Duration(delayMultiplier^attempt)):
case <-time.After(initialRetryDelay * time.Duration(1<<attempt)):
// Sleep completed, continue to the next attempt.
}
}
Expand Down