fix: use pointer type for AddWatermark to allow disabling watermarks#791
Open
mahesh-sadupalli wants to merge 1 commit into
Open
fix: use pointer type for AddWatermark to allow disabling watermarks#791mahesh-sadupalli wants to merge 1 commit into
mahesh-sadupalli wants to merge 1 commit into
Conversation
Change AddWatermark from bool to *bool in GenerateImagesConfig so that explicit false values are serialized instead of being dropped by omitempty. This allows users to disable watermarks via the API. Fixes googleapis#714
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AddWatermarkfromboolto*boolinGenerateImagesConfigstructfalsevalues are serialized in JSON instead of being dropped byomitemptyAddWatermarkfields in the codebase which already use*boolFixes #714
Test plan
go build ./...passes"addWatermark": falsewhen set