chore(resumable-media): add prerelease_deps and core_deps_from_source nox sessions#17341
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements the prerelease_deps and core_deps_from_source sessions in noxfile.py to run tests with pre-release dependencies and core dependencies from source. However, a critical issue was identified in core_deps_from_source where it assumes dependencies like google-crc32c and google-auth exist locally in the packages/ directory, which will cause failures since they reside in separate repositories. It is recommended to dynamically check for local existence and fall back to PyPI, as suggested by the reviewer.
daniel-sanche
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds missing
prerelease_depsandcore_deps_from_sourcenox sessions for the google-resumable-media package.Changes to each nox session are based on the versions found in the gapic-generator
noxfile.py.j2template.Fixes #17053