chore(ndb): add missing format session and modernize lint and blacken sessions#17342
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modernizes the codebase's formatting and import sorting by integrating Ruff into the development workflow, updating the linting sessions in noxfile.py, and cleaning up imports across numerous files. Feedback on these changes highlights two issues: first, the flake8 linting execution was accidentally omitted from the updated lint session in noxfile.py, leaving only formatting checks active; second, a typo ('functionother') in an error message within query.py should be corrected by adding a missing space.
chalmerlowe
force-pushed
the
chore/add-nox-session-google-cloud-ndb
branch
from
222bf2d to
56c04b2
Compare
chalmerlowe
force-pushed
the
chore/add-nox-session-google-cloud-ndb
branch
from
56c04b2 to
aab9958
Compare
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
daniel-sanche
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds missing
formatnox session and modernizeslintandblackensessions to use Ruff for this package.Additional changes:
blackenas deprecated.Changes to each nox session are based on the versions found in the gapic-generator
noxfile.py.j2template.Fixes #17049