Repository navigation
feat(clustering): propagate contentDescription to marker options for accessibility #1035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dkhawk
wants to merge
3
commits into
main
Choose a base branch
from
fix/clustering-content-description
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
80 changes: 80 additions & 0 deletions
80
.../java/com/google/maps/android/compose/clustering/ClusterRendererContentDescriptionTest.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| /* | ||
| * Copyright 2026 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.google.maps.android.compose.clustering | ||
|
|
||
| import com.google.android.gms.maps.model.LatLng | ||
| import com.google.maps.android.clustering.Cluster | ||
| import com.google.maps.android.clustering.ClusterItem | ||
| import org.junit.Assert.assertEquals | ||
| import org.junit.Assert.assertNull | ||
| import org.junit.Test | ||
|
|
||
| public class ClusterRendererContentDescriptionTest { | ||
|
|
||
| private class TestClusterItem( | ||
| override val position: LatLng, | ||
| override val title: String?, | ||
| override val snippet: String? = null, | ||
| override val zIndex: Float? = null, | ||
| ) : ClusterItem | ||
|
|
||
| private class TestCluster<T : ClusterItem>( | ||
| override val items: Collection<T>, | ||
| override val position: LatLng, | ||
| ) : Cluster<T> { | ||
| override val size: Int get() = items.size | ||
| } | ||
|
|
||
| @Test | ||
| public fun testResolveItemContentDescriptionFallsBackToItemTitleWhenNull() { | ||
| val item = TestClusterItem(LatLng(1.0, 2.0), title = "Store 42") | ||
| val result = resolveItemContentDescription(item, customContentDescription = null) | ||
| assertEquals("Store 42", result) | ||
| } | ||
|
|
||
| @Test | ||
| public fun testResolveItemContentDescriptionCustomOverridesItemTitle() { | ||
| val item = TestClusterItem(LatLng(1.0, 2.0), title = "Store 42") | ||
| val result = resolveItemContentDescription( | ||
| item, | ||
| customContentDescription = "Custom Accessibility Pin" | ||
| ) | ||
| assertEquals("Custom Accessibility Pin", result) | ||
| } | ||
|
|
||
| @Test | ||
| public fun testResolveItemContentDescriptionReturnsNullWhenBothNull() { | ||
| val item = TestClusterItem(LatLng(1.0, 2.0), title = null) | ||
| val result = resolveItemContentDescription(item, customContentDescription = null) | ||
| assertNull(result) | ||
| } | ||
|
|
||
| @Test | ||
| public fun testResolveClusterContentDescription() { | ||
| val item = TestClusterItem(LatLng(1.0, 2.0), title = "Item") | ||
| val cluster = TestCluster(listOf(item), LatLng(1.0, 2.0)) | ||
|
|
||
| val customResult = resolveClusterContentDescription( | ||
| cluster, | ||
| customContentDescription = "Cluster of 1 location" | ||
| ) | ||
| assertEquals("Cluster of 1 location", customResult) | ||
|
|
||
| val defaultResult = resolveClusterContentDescription(cluster, customContentDescription = null) | ||
| assertNull(defaultResult) | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a parameter to a public composable changes its JVM signature, so anything compiled against 9.0.x that calls
ClusteringMarkerProperties(...)would fail withNoSuchMethodErroruntil it is recompiled. Could we keep the old signature as a@Deprecated(level = DeprecationLevel.HIDDEN)overload that delegates to the new one? That keeps it binary compatible, as AGENTS.md asks for public API changes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Added the 3-parameter
ClusteringMarkerPropertiesoverload marked@Deprecated(level = DeprecationLevel.HIDDEN)delegating to the 4-parameter version, preserving binary compatibility for pre-compiled binaries.