chore(kmp-demo): add shared multiplatform Location Flow demo by dkhawk · Pull Request #1038 · googlemaps/android-maps-compose

dkhawk · 2026-10-09T23:02:42Z

Summary

Adds a shared Location Flow demo (LocationFlowDemo) to :maps-compose-multiplatform-demo exercising the multiplatform Location, LocationSource, and LocationPriority APIs from googlemaps/android-maps-utils#1817 across Android and iOS:

Dependency Wiring (gradle/libs.versions.toml, maps-compose-multiplatform/build.gradle.kts, settings.gradle.kts):
- Adds maps-utils-kmp-core (com.google.maps.android:android-maps-utils-core) and exposes it via api(libs.maps.utils.kmp.core) in :maps-compose-multiplatform commonMain.
- Scopes mavenLocal() in settings.gradle.kts (when useMavenLocal=true) to includeGroup("com.google.maps.android") so local KMP snapshot testing does not conflict with external dependencies.
Platform Location & Permission Controller (PlatformLocationSource.kt, PlatformLocationSource.android.kt, PlatformLocationSource.ios.kt):
- Implements rememberPlatformLocationController() backed by LocationManager on Android and CLLocationManager.asLocationSource() on iOS, tracking runtime location permission state and providing permission request / system settings actions.
Shared LocationFlowDemo (DemoApp.kt, Demos.kt):
- Collects LocationSource.locationEvents() in commonMain to animate the camera, update a live Marker, render a horizontal accuracy Circle, and draw a breadcrumb Polyline trail, with interactive High Accuracy / Balanced priority switching and runtime permission recovery controls.
App Manifests & Xcode Project Generation (maps-app/src/main/AndroidManifest.xml, iosApp/iosApp/Info.plist, iosApp/create_project.rb):
- Declares ACCESS_COARSE_LOCATION and ACCESS_FINE_LOCATION in maps-app and NSLocationWhenInUseUsageDescription in iosApp.
- Updates iosApp/create_project.rb to check IOS_MAPS_API_KEY in secrets.properties before falling back to MAPS_API_KEY.

Note: Depends on googlemaps/android-maps-utils#1817 being merged and published to 6.1.0-SNAPSHOT for CI resolution.

Testing

Verified live on physical Android device (Pixel 6) and physical iOS device (iPhone 14) as well as iOS Simulator.

…Android and MapKit on iOS

…aps iOS SDK via CocoaPods

… to 10.14.0

…anch Adds common-code clustering to maps-compose-multiplatform via the experimental KMP modules of android-maps-utils (maps-model, clustering): clusterMarkers() runs NonHierarchicalDistanceBasedAlgorithm in commonMain and ClusteredGoogleMap renders the resulting clusters, so Android and iOS produce identical clusters from shared code. Consumption paths (see settings.gradle.kts): publishToMavenLocal from ../android-maps-utils plus -PuseMavenLocal=true (full build works, this is the default), or -PuseLocalMapsUtils=true for a composite build (platform compilations work; shared-metadata compilation is skipped by Kotlin's granular-metadata transform across included builds and fails). Note: linkPodDebugFrameworkIosArm64 fails on this branch with or without this change (Kotlin/Native cache failure on compose-ui 1.7.3 uikitarm64); simulator link and all target compilations pass. Claude-Session: https://claude.ai/code/session_01225X6MnAqkyCF7Xones6WY

The maps-compose-multiplatform module now depends on com.google.maps.android:maps-model and :clustering from the feat/experimental-kmp-clustering branch of android-maps-utils, which are not published to any remote repository. Check out that branch and publish the two modules to the runner's mavenLocal in the lint, test and instrumentation workflows, and set USE_MAVEN_LOCAL so the compose build resolves them from there. Claude-Session: https://claude.ai/code/session_01225X6MnAqkyCF7Xones6WY

com.google.maps.android:clustering duplicated the classes of the android-maps-utils-clustering AAR that maps-compose-utils pulls from Maven Central, failing maps-app's checkDebugDuplicateClasses. Depend on android-maps-utils-clustering / android-maps-utils-maps-model instead (matching the renamed KMP publications) so Gradle resolves both paths to one module; mavenLocal shadows the Central AAR with the API-compatible KMP artifact. Claude-Session: https://claude.ai/code/session_01225X6MnAqkyCF7Xones6WY

…build

…-module-snapshot

…OS CI - KmpPublishingConventionPlugin: explicit API mode, iosArm64 and iosSimulatorArm64, lint, Kover and Maven Central publishing as maps-compose-multiplatform - Public API checks for the iOS klibs (Kotlin ABI validation) and the Android target (binary-compatibility-validator), in api/ - Publishing a release fails while it depends on a maps-utils snapshot - New macOS workflow builds the iOS targets and the iOS demo app - The publish workflow runs on macOS, which the iOS klibs need

…ment the KMP build - commonTest for clusterMarkers, run as Android host tests and on the iOS simulator - iosApp/README.md replaces BUILD_KMP.md; the Xcode project is generated by create_project.rb and no longer checked in - AGENTS.md describes the multiplatform module, its API checks and the snapshot dependency

…-multiplatform Replaces the prototype API with one that follows maps-compose: - GoogleMap(cameraPositionState, properties, uiSettings, onMapClick, onMapLongClick, onMapLoaded) { content } - CameraPositionState follows the map both ways and can animate - Marker with MarkerState (draggable, tappable, tinted pin), Polyline, Polygon with holes and Circle; each keeps one native object per call instead of clearing the map on every update - Clustering reclusters as the camera zooms and zooms in on cluster taps - Line widths are density-independent on both platforms Demos move to maps-compose-multiplatform-demo, shared by maps-app and the iOS app, which now hosts them instead of a Swift list. Tests cover the camera state, content registration and clustering on the JVM and iOS.

…ormLocationSource.android.kt

github-actions · 2026-10-12T04:14:31Z

Coverage (unit tests)

Compared against 85a56aa on feat/experimental-kmp-module (#1034).

Module	Line %	Change	Branch %	Change
`maps-compose`	0.00%	no change	0.00%	no change
`maps-compose-multiplatform`	61.63%	new	26.40%	new
`maps-compose-utils`	2.04%	no change	0.49%	no change
`maps-compose-widgets`	0.00%	no change	0.00%	no change
TOTAL	8.54%	🔺 +8.13	3.17%	🔺 +3.08

_{Line and branch coverage from unit test reports. History is recorded on the coverage-history branch after each merge to feat/experimental-kmp-module.}

googlemaps-bot · 2026-10-12T04:24:38Z

Code Coverage

Overall Project	44.37%	🍏

There is no coverage information present for the Files changed

kikoso

Nice demo, @dkhawk ! A few comments, mostly about the permission handling. Also, since this only touches the demo app, let's mark it as a chore instead of feat, to avoid releasing a new version.

kikoso · 2026-10-12T04:35:58Z

+    LaunchedEffect(appContext) {
+        while (true) {
+            hasPermission = appContext.hasAnyLocationPermission()
+            delay(500L)
+        }
+    }


Polling the permission every 500ms works, but it keeps a loop running for as long as the demo is on screen. Could we re-check it on ON_RESUME with a LifecycleEventObserver instead? That covers both the system dialog and coming back from Settings. What do you think?

Good call! Replaced the 500ms polling loop in PlatformLocationSource.android.kt with a LifecycleEventObserver in DisposableEffect(lifecycleOwner, appContext) that re-checks permission on Lifecycle.Event.ON_RESUME (and also replaced the polling loop on iOS with CLLocationManagerDelegateProtocol.locationManagerDidChangeAuthorization + UIApplicationDidBecomeActiveNotification).

kikoso · 2026-10-12T04:35:58Z

+                Handler(Looper.getMainLooper()).postDelayed({
+                    if (!appContext.hasAnyLocationPermission() && activity.hasWindowFocus()) {
+                        openAppSettings()
+                    }
+                }, 300L)


I am thinking out loud if the 300ms window focus heuristic could misfire on slower devices, where the permission dialog takes longer to appear and we would open Settings on top of it. Would it make sense to use shouldShowRequestPermissionRationale (or an ActivityResultLauncher) to detect the permanently denied case instead?

Agreed—switched to rememberLauncherForActivityResult(ActivityResultContracts.RequestMultiplePermissions()) combined with checking shouldShowRequestPermissionRationale before and after the request (!rationaleBeforeRequest && !rationaleAfterRequest) so permanently denied permissions are detected deterministically in the result callback without any timer or window-focus heuristic.

kikoso · 2026-10-12T04:35:58Z

+    <uses-permission android:name="android.permission.ACCESS_COARSE_LOCATION" />
+    <uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" />


Just to understand it: do we need the location permissions in maps-app, or is this demo only launched from the multiplatform demo module? If maps-app does not use location, we could keep these permissions out of its manifest.

On Android, :maps-compose-multiplatform-demo is an Android KMP library module hosted by KmpMapActivity inside :maps-app. I reverted maps-app/src/main/AndroidManifest.xml and moved the <uses-permission> declarations into maps-compose-multiplatform-demo/src/androidMain/AndroidManifest.xml so maps-app's own manifest stays untouched while AGP's manifest merger still contributes the permissions for KmpMapActivity.

kikoso · 2026-10-12T04:35:58Z

+            if (trail.lastOrNull() != target) {
+                trail += target
+            }


nit: the trail grows without limit while the demo is open. For a demo it is probably fine, but should we cap it (e.g. last 500 points) to avoid an ever growing polyline?

Done—added MAX_TRAIL_POINTS = 500 in Demos.kt to cap the trail list at the most recent 500 points.

…-demo

…fest, and trail cap

googlemaps-bot · 2026-10-13T17:46:30Z

Coverage (instrumentation tests)

Overall Project	44.41%	🍏

There is no coverage information present for the Files changed

kikoso and others added 13 commits October 1, 2026 14:49

feat: introduce experimental KMP maps module wrapping Google Maps on …

fd22127

…Android and MapKit on iOS

feat: migrate iOS multiplatform map implementation to native Google M…

36c1c1b

…aps iOS SDK via CocoaPods

feat: add interactive maps demos to iOS app & upgrade Google Maps SDK…

73f6bc4

… to 10.14.0

fix(ios): declare DeveloperSecrets.swift output path & add BUILD_KMP.md

f173701

build: consume the maps-utils 6.1.0-SNAPSHOT instead of a mavenLocal …

94a8178

…build

Merge remote-tracking branch 'origin/main' into feat/experimental-kmp…

57273b2

…-module-snapshot

feat(kmp-demo): add shared multiplatform Location Flow demo

425cec8

dkhawk requested a review from kikoso October 9, 2026 23:02

docs(kmp-demo): add TODO referencing android-maps-utils#1818 in Platf…

06f7bc4

…ormLocationSource.android.kt

kikoso reviewed Oct 12, 2026

View reviewed changes

kikoso force-pushed the feat/experimental-kmp-module branch from cda70c2 to 54c5bb8 Compare October 12, 2026 04:36

kikoso requested a review from a team as a code owner October 12, 2026 04:36

dkhawk added 2 commits October 13, 2026 11:22

chore: merge feat/experimental-kmp-module into feat/kmp-location-flow…

c30ec6e

…-demo

chore(kmp-demo): address review feedback on permission handling, mani…

dfe76f6

…fest, and trail cap

dkhawk changed the title ~~feat(kmp-demo): add shared multiplatform Location Flow demo~~ chore(kmp-demo): add shared multiplatform Location Flow demo Oct 13, 2026

Navigation Menu

Repository navigation

chore(kmp-demo): add shared multiplatform Location Flow demo - #1038

chore(kmp-demo): add shared multiplatform Location Flow demo#1038
dkhawk wants to merge 16 commits into
feat/experimental-kmp-modulefrom
feat/kmp-location-flow-demo

dkhawk commented Oct 9, 2026

Uh oh!

github-actions Bot commented Oct 12, 2026

Uh oh!

googlemaps-bot commented Oct 12, 2026

Uh oh!

kikoso left a comment

Uh oh!

kikoso Oct 12, 2026

Uh oh!

dkhawk Oct 13, 2026

Uh oh!

kikoso Oct 12, 2026

Uh oh!

dkhawk Oct 13, 2026

Uh oh!

kikoso Oct 12, 2026

Uh oh!

dkhawk Oct 13, 2026

Uh oh!

kikoso Oct 12, 2026

Uh oh!

dkhawk Oct 13, 2026

Uh oh!

googlemaps-bot commented Oct 13, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		<uses-permission android:name="android.permission.ACCESS_COARSE_LOCATION" />
		<uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" />

Conversation

dkhawk commented Oct 9, 2026

Summary

Testing

Uh oh!

github-actions Bot commented Oct 12, 2026

Coverage (unit tests)

Uh oh!

googlemaps-bot commented Oct 12, 2026

Code Coverage

Uh oh!

kikoso left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

googlemaps-bot commented Oct 13, 2026

Coverage (instrumentation tests)

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants