Repository navigation
fix(widgets): preserve fractional scale bar distances - #1045
Draft
premsinghsodha7 wants to merge 2 commits into
Draft
premsinghsodha7 wants to merge 2 commits into
premsinghsodha7 wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #233.
ScaleBar truncates kilometre and mile labels to integers: 1,900 m is labelled
1 km, and 3,200 m is labelled1 miinstead of about 1.99 miles. Preserve fractional values using the locale decimal separator and at most two decimal places. Whole metres and feet keep their existing formatting; exactly 1,000 m now uses1 km. No new dependencies or public API changes.Validation:
1.98 kmand1.23 miare displayed on light and dark backgrounds. Both captured widget images were visually inspected.Maps API key not specified; live map tiles/projection integration remains unverified.:maps-app:lintDebug,spotlessCheck, andgit diff --checkpassed.The device rendering tests use a mocked projection and need no API key. Production drawing and projection calculation are unchanged.
Created as a draft per repository guidance for review of the label-precision approach.