fix(lwdid): preserve fitted overall inference - #1
Open
shawcharles wants to merge 2 commits into
Open
Conversation
This was referenced Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the bounded result-provenance fix in igerber#733.
LWDiD.fit()already computes and stores the canonical overall ATT and its inference.LWDiDResults.aggregate(\"overall\")previously replaced that result with a separate aggregation built from marginal cohort effects and their standard errors. That could change the point estimate and discarded the composite-regression joint inference where it was available.This change returns an equivalent result object containing the fitted canonical result instead of reconstructing a second estimator.
This does not establish the validity of the non-composite delta-method variance used by
fit()for other staggered paths. That path still omits cross-cohort covariance; this PR ensuresaggregate()no longer hides its provenance by replacing it with a different calculation. The remaining statistical work is tracked in igerber#735.Test
df_inferencebetweenfit()andaggregate(\"overall\").tests/test_lwdid.py: 64 passed.This PR targets the source branch of igerber#588 so it can be merged there directly.