Skip to content

test: fix assertion messages and add TestProxyHeaders_NoHeaders in proxy_headers_test.go #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aoright wants to merge 1 commit into
base: main
Choose a base branch
from
+34 −2
Open

test: fix assertion messages and add TestProxyHeaders_NoHeaders in proxy_headers_test.go #269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 34 additions & 2 deletions proxy_headers_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,11 +101,43 @@ func TestProxyHeaders(t *testing.T) {
}

if proto != r.Header.Get(xForwardedProto) {
t.Fatalf("wrong address: got %s want %s", proto,
t.Fatalf("wrong proto: got %s want %s", proto,
r.Header.Get(xForwardedProto))
}
if host != r.Header.Get(xForwardedHost) {
t.Fatalf("wrong address: got %s want %s", host,
t.Fatalf("wrong host: got %s want %s", host,
r.Header.Get(xForwardedHost))
}
}

func TestProxyHeaders_NoHeaders(t *testing.T) {
rr := httptest.NewRecorder()
r := newRequest(http.MethodGet, "http://localhost:8080/")
r.RemoteAddr = "127.0.0.1:12345"

var (
addr string
proto string
host string
)
ProxyHeaders(http.HandlerFunc(
func(w http.ResponseWriter, r *http.Request) {
addr = r.RemoteAddr
proto = r.URL.Scheme
host = r.Host
})).ServeHTTP(rr, r)

if rr.Code != http.StatusOK {
t.Fatalf("bad status: got %d want %d", rr.Code, http.StatusOK)
}

if addr != "127.0.0.1:12345" {
t.Fatalf("wrong address: got %s want %s", addr, "127.0.0.1:12345")
}
if proto != "http" {
t.Fatalf("wrong proto: got %s want %s", proto, "http")
}
if host != "localhost:8080" {
t.Fatalf("wrong host: got %s want %s", host, "localhost:8080")
}
}
Loading